Re: [PATCH 5/3] refs: pass NULL to resolve_refdup() if hash is not needed

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2017, 08:29 UTC
Message-ID: <xmqqfub3uv8p.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <c18156ec-4c59-eb96-3177-0b1085b0a5c1@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 11 quoted lines

> This allows us to get rid of several write-only variables.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  builtin/checkout.c     | 3 +--
>  builtin/receive-pack.c | 3 +--
>  ref-filter.c           | 7 ++-----
>  reflog-walk.c          | 6 ++----
>  transport.c            | 3 +--
>  wt-status.c            | 4 +---
>  6 files changed, 8 insertions(+), 18 deletions(-)

Both patches looked good to me.

It's a bit surprising that we care so much about where a symbolic ref points at, but it is understandable from the list of files affected.