threads / patch / 8895

patchgit-gui: Allow users to set commit.signoff from options.

Subject: [PATCH] git-gui: Allow users to set commit.signoff from options.

## tl;dr

3 messages between Jul 6, 2007 and Jul 9, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Gerrit Pape· Jul 6, 2007, 14:46 UTC · lore

Users may want to automatically sign-off any commit for a specific repository. If they are mostly a git-gui user they should be able to view/set this option from within the git-gui environment, rather than needing to edit a raw text file on their local filesystem.

This was noticed and requested by Josh Triplett through
 http://bugs.debian.org/412776

Signed-off-by: Gerrit Pape <pape@smarden.org>
---
 git-gui.sh     |    1 +
 lib/option.tcl |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

Show changes to 2 files +2 −0

git-gui.sh, lib/option.tcl

diff --git a/git-gui.sh b/git-gui.sh
index 0096f49..5ded736 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1295,6 +1295,7 @@ set default_config(merge.summary) false
 set default_config(merge.verbosity) 2
 set default_config(user.name) {}
 set default_config(user.email) {}
+set default_config(commit.signoff) false
 
 set default_config(gui.pruneduringfetch) false
 set default_config(gui.trustmtime) false
diff --git a/lib/option.tcl b/lib/option.tcl
index ae19a8f..28208ce 100644
--- a/lib/option.tcl
+++ b/lib/option.tcl
@@ -188,6 +188,7 @@ proc do_options {} {
 		{b merge.summary {Summarize Merge Commits}}
 		{i-1..5 merge.verbosity {Merge Verbosity}}
 		{b merge.diffstat {Show Diffstat After Merge}}
+		{b commit.signoff {Automatically Sign-off}}
 
 		{b gui.trustmtime  {Trust File Modification Timestamps}}
 		{b gui.pruneduringfetch {Prune Tracking Branches During Fetch}}

-- 
1.5.2.1

Shawn O. Pearce· Jul 8, 2007, 21:48 UTC · re: Gerrit Pape · lore

Re: [PATCH] git-gui: Allow users to set commit.signoff from options.

Gerrit Pape <pape@smarden.org> wrote:

> Users may want to automatically sign-off any commit for a specific
> repository.  If they are mostly a git-gui user they should be able to
> view/set this option from within the git-gui environment, rather than
> needing to edit a raw text file on their local filesystem.

Sure. But your patch to git-gui actually just lets the user set the flag, but doesn't make git-gui honor it. So the user can set "Automatically Sign-Off" through git-gui but it will have no effect within git-gui (git-gui doesn't use git-commit.sh, it has its own pure-Tcl implementation).

I'm not applying this to git-gui, for the very same reason that Junio already gave as to why he won't apply the git-commit.sh patch.

Within git-gui adding a signoff is either one mouse click (the
button on the toolbar), a single keystroke (Ctrl-S) or a menu action
(Commit->Signoff).  Three easy ways to insert the signoff line.
But it still needs to be a choice from the user, every time they
make a commit.

-- 
Shawn.

Gerrit Pape· Jul 9, 2007, 07:43 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] git-gui: Allow users to set commit.signoff from options.

On Sun, Jul 08, 2007 at 05:48:32PM -0400, Shawn O. Pearce wrote:

Show 11 quoted lines

> Gerrit Pape <pape@smarden.org> wrote:
> > Users may want to automatically sign-off any commit for a specific
> > repository.  If they are mostly a git-gui user they should be able to
> > view/set this option from within the git-gui environment, rather than
> > needing to edit a raw text file on their local filesystem.
> 
> Sure.  But your patch to git-gui actually just lets the user set
> the flag, but doesn't make git-gui honor it.  So the user can set
> "Automatically Sign-Off" through git-gui but it will have no effect
> within git-gui (git-gui doesn't use git-commit.sh, it has its own
> pure-Tcl implementation).

Ups, sorry.

Show 8 quoted lines

> I'm not applying this to git-gui, for the very same reason that
> Junio already gave as to why he won't apply the git-commit.sh patch.
> 
> Within git-gui adding a signoff is either one mouse click (the
> button on the toolbar), a single keystroke (Ctrl-S) or a menu action
> (Commit->Signoff).  Three easy ways to insert the signoff line.
> But it still needs to be a choice from the user, every time they
> make a commit.

Yes, thanks, Gerrit.