{"thread":{"id":"8895","subject":"[PATCH] git-gui: Allow users to set commit.signoff from options.","startedAt":"2007-07-06T14:46:54Z","lastAt":"2007-07-09T07:43:14Z","messageCount":3,"participants":["Gerrit Pape","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"46628","messageId":"20070706144654.12095.qmail@c8e1b1dc78de94.315fe32.mid.smarden.org","threadId":"8895","inReplyTo":null,"subject":"[PATCH] git-gui: Allow users to set commit.signoff from options.","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2007-07-06T14:46:54Z","receivedAt":"2007-07-06T14:46:54Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"Users may want to automatically sign-off any commit for a specific\nrepository.  If they are mostly a git-gui user they should be able to\nview/set this option from within the git-gui environment, rather than\nneeding to edit a raw text file on their local filesystem.\n\nThis was noticed and requested by Josh Triplett through\n http://bugs.debian.org/412776\n\nSigned-off-by: Gerrit Pape <pape@smarden.org>\n---\n git-gui.sh     |    1 +\n lib/option.tcl |    1 +\n 2 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex 0096f49..5ded736 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -1295,6 +1295,7 @@ set default_config(merge.summary) false\n set default_config(merge.verbosity) 2\n set default_config(user.name) {}\n set default_config(user.email) {}\n+set default_config(commit.signoff) false\n \n set default_config(gui.pruneduringfetch) false\n set default_config(gui.trustmtime) false\ndiff --git a/lib/option.tcl b/lib/option.tcl\nindex ae19a8f..28208ce 100644\n--- a/lib/option.tcl\n+++ b/lib/option.tcl\n@@ -188,6 +188,7 @@ proc do_options {} {\n \t\t{b merge.summary {Summarize Merge Commits}}\n \t\t{i-1..5 merge.verbosity {Merge Verbosity}}\n \t\t{b merge.diffstat {Show Diffstat After Merge}}\n+\t\t{b commit.signoff {Automatically Sign-off}}\n \n \t\t{b gui.trustmtime  {Trust File Modification Timestamps}}\n \t\t{b gui.pruneduringfetch {Prune Tracking Branches During Fetch}}\n-- \n1.5.2.1\n"},{"id":"46798","messageId":"20070708214832.GC4436@spearce.org","threadId":"8895","inReplyTo":"20070706144654.12095.qmail@c8e1b1dc78de94.315fe32.mid.smarden.org","subject":"Re: [PATCH] git-gui: Allow users to set commit.signoff from options.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-08T21:48:32Z","receivedAt":"2007-07-08T21:48:32Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Gerrit Pape <pape@smarden.org> wrote:\n> Users may want to automatically sign-off any commit for a specific\n> repository.  If they are mostly a git-gui user they should be able to\n> view/set this option from within the git-gui environment, rather than\n> needing to edit a raw text file on their local filesystem.\n\nSure.  But your patch to git-gui actually just lets the user set\nthe flag, but doesn't make git-gui honor it.  So the user can set\n\"Automatically Sign-Off\" through git-gui but it will have no effect\nwithin git-gui (git-gui doesn't use git-commit.sh, it has its own\npure-Tcl implementation).\n\nI'm not applying this to git-gui, for the very same reason that\nJunio already gave as to why he won't apply the git-commit.sh patch.\n\nWithin git-gui adding a signoff is either one mouse click (the\nbutton on the toolbar), a single keystroke (Ctrl-S) or a menu action\n(Commit->Signoff).  Three easy ways to insert the signoff line.\nBut it still needs to be a choice from the user, every time they\nmake a commit.\n \n-- \nShawn.\n"},{"id":"46840","messageId":"20070709074314.18158.qmail@dd40bf21a4abfd.315fe32.mid.smarden.org","threadId":"8895","inReplyTo":"20070708214832.GC4436@spearce.org","subject":"Re: [PATCH] git-gui: Allow users to set commit.signoff from options.","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2007-07-09T07:43:14Z","receivedAt":"2007-07-09T07:43:14Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"On Sun, Jul 08, 2007 at 05:48:32PM -0400, Shawn O. Pearce wrote:\n> Gerrit Pape <pape@smarden.org> wrote:\n> > Users may want to automatically sign-off any commit for a specific\n> > repository.  If they are mostly a git-gui user they should be able to\n> > view/set this option from within the git-gui environment, rather than\n> > needing to edit a raw text file on their local filesystem.\n> \n> Sure.  But your patch to git-gui actually just lets the user set\n> the flag, but doesn't make git-gui honor it.  So the user can set\n> \"Automatically Sign-Off\" through git-gui but it will have no effect\n> within git-gui (git-gui doesn't use git-commit.sh, it has its own\n> pure-Tcl implementation).\n\nUps, sorry.\n\n> I'm not applying this to git-gui, for the very same reason that\n> Junio already gave as to why he won't apply the git-commit.sh patch.\n> \n> Within git-gui adding a signoff is either one mouse click (the\n> button on the toolbar), a single keystroke (Ctrl-S) or a menu action\n> (Commit->Signoff).  Three easy ways to insert the signoff line.\n> But it still needs to be a choice from the user, every time they\n> make a commit.\n\nYes, thanks, Gerrit.\n"}]}