# [PATCH] git-gui: Allow users to set commit.signoff from options. 3 messages from 2007-07-06 to 2007-07-09. Participants: Gerrit Pape, Shawn O. Pearce. Thread: https://gitlist.dev/t/8895 ## Gerrit Pape, 2007-07-06 14:46 Subject: [PATCH] git-gui: Allow users to set commit.signoff from options. Message-ID: <20070706144654.12095.qmail@c8e1b1dc78de94.315fe32.mid.smarden.org> URL: https://gitlist.dev/e/20070706144654.12095.qmail%40c8e1b1dc78de94.315fe32.mid.smarden.org ``` Users may want to automatically sign-off any commit for a specific repository. If they are mostly a git-gui user they should be able to view/set this option from within the git-gui environment, rather than needing to edit a raw text file on their local filesystem. This was noticed and requested by Josh Triplett through http://bugs.debian.org/412776 Signed-off-by: Gerrit Pape --- git-gui.sh | 1 + lib/option.tcl | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/git-gui.sh b/git-gui.sh index 0096f49..5ded736 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -1295,6 +1295,7 @@ set default_config(merge.summary) false set default_config(merge.verbosity) 2 set default_config(user.name) {} set default_config(user.email) {} +set default_config(commit.signoff) false set default_config(gui.pruneduringfetch) false set default_config(gui.trustmtime) false diff --git a/lib/option.tcl b/lib/option.tcl index ae19a8f..28208ce 100644 --- a/lib/option.tcl +++ b/lib/option.tcl @@ -188,6 +188,7 @@ proc do_options {} { {b merge.summary {Summarize Merge Commits}} {i-1..5 merge.verbosity {Merge Verbosity}} {b merge.diffstat {Show Diffstat After Merge}} + {b commit.signoff {Automatically Sign-off}} {b gui.trustmtime {Trust File Modification Timestamps}} {b gui.pruneduringfetch {Prune Tracking Branches During Fetch}} -- 1.5.2.1 ``` ## Shawn O. Pearce, 2007-07-08 21:48 Subject: Re: [PATCH] git-gui: Allow users to set commit.signoff from options. Message-ID: <20070708214832.GC4436@spearce.org> URL: https://gitlist.dev/e/20070708214832.GC4436%40spearce.org In-Reply-To: <20070706144654.12095.qmail@c8e1b1dc78de94.315fe32.mid.smarden.org> ``` Gerrit Pape wrote: > Users may want to automatically sign-off any commit for a specific > repository. If they are mostly a git-gui user they should be able to > view/set this option from within the git-gui environment, rather than > needing to edit a raw text file on their local filesystem. Sure. But your patch to git-gui actually just lets the user set the flag, but doesn't make git-gui honor it. So the user can set "Automatically Sign-Off" through git-gui but it will have no effect within git-gui (git-gui doesn't use git-commit.sh, it has its own pure-Tcl implementation). I'm not applying this to git-gui, for the very same reason that Junio already gave as to why he won't apply the git-commit.sh patch. Within git-gui adding a signoff is either one mouse click (the button on the toolbar), a single keystroke (Ctrl-S) or a menu action (Commit->Signoff). Three easy ways to insert the signoff line. But it still needs to be a choice from the user, every time they make a commit. -- Shawn. ``` ## Gerrit Pape, 2007-07-09 07:43 Subject: Re: [PATCH] git-gui: Allow users to set commit.signoff from options. Message-ID: <20070709074314.18158.qmail@dd40bf21a4abfd.315fe32.mid.smarden.org> URL: https://gitlist.dev/e/20070709074314.18158.qmail%40dd40bf21a4abfd.315fe32.mid.smarden.org In-Reply-To: <20070708214832.GC4436@spearce.org> ``` On Sun, Jul 08, 2007 at 05:48:32PM -0400, Shawn O. Pearce wrote: > Gerrit Pape wrote: > > Users may want to automatically sign-off any commit for a specific > > repository. If they are mostly a git-gui user they should be able to > > view/set this option from within the git-gui environment, rather than > > needing to edit a raw text file on their local filesystem. > > Sure. But your patch to git-gui actually just lets the user set > the flag, but doesn't make git-gui honor it. So the user can set > "Automatically Sign-Off" through git-gui but it will have no effect > within git-gui (git-gui doesn't use git-commit.sh, it has its own > pure-Tcl implementation). Ups, sorry. > I'm not applying this to git-gui, for the very same reason that > Junio already gave as to why he won't apply the git-commit.sh patch. > > Within git-gui adding a signoff is either one mouse click (the > button on the toolbar), a single keystroke (Ctrl-S) or a menu action > (Commit->Signoff). Three easy ways to insert the signoff line. > But it still needs to be a choice from the user, every time they > make a commit. Yes, thanks, Gerrit. ```