threads / patch / 8380

patchMake the installation target of git-gui a little less chatty

Subject: [PATCH] Make the installation target of git-gui a little less chatty

## tl;dr

4 messages between May 31, 2007 and Jun 1, 2007. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Alex Riesen· May 31, 2007, 22:25 UTC · lore

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

The patch is hand-tuned to start in git-gui, so that it can be applied in git-gui repo.

 Makefile |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)

Show changes to Makefile +11 −6

diff --git a/Makefile b/Makefile
index 3de0de1..1eafbf8 100644
--- a/Makefile
+++ b/Makefile
@@ -2,6 +2,10 @@ all::
 
 # Define V=1 to have a more verbose compile.
 #
+QUIET =
+ifndef V
+    QUIET = @
+endif
 
 GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE
 	@$(SHELL_PATH) ./GIT-VERSION-GEN
@@ -109,12 +113,13 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS
 all:: $(ALL_PROGRAMS) lib/tclIndex
 
 install: all
-	$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
-	$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
-	$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
-	$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'
-	$(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'
-	$(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)
+	@echo installing git-gui
+	$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
+	$(QUIET)$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
+	$(QUIET)$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
+	$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'
+	$(QUIET)$(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'
+	$(QUIET)$(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)
 
 dist-version:
 	@mkdir -p $(TARDIR)

-- 
1.5.2.162.gbaa1f

Shawn O. Pearce· Jun 1, 2007, 03:02 UTC · re: Alex Riesen · lore

Re: [PATCH] Make the installation target of git-gui a little less chatty

Alex Riesen <raa.lkml@gmail.com> wrote:

> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---

I have the exact same reaction as Junio had to the same change in
git.git...  I'll apply it if you resend according to his guidelines.

> The patch is hand-tuned to start in git-gui, so that it can be applied
> in git-gui repo.

Hand-tuning the patch isn't necessary, just making the change its own patch is all that is required. Git has these nifty flags for git-am like -p2 and -3 that make editing filenames in the patch completely unnecessary. ;-)

-- 
Shawn.

Alex Riesen· Jun 1, 2007, 07:36 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] Make the installation target of git-gui a little less chatty

On 6/1/07, Shawn O. Pearce <spearce@spearce.org> wrote:

Show 5 quoted lines

> > The patch is hand-tuned to start in git-gui, so that it can be applied
> > in git-gui repo.
>
> Hand-tuning the patch isn't necessary, just making the change its
> own patch is all that is required.  Git has these nifty flags for

Good to know

Alex Riesen· Jun 1, 2007, 23:09 UTC · re: Shawn O. Pearce · lore

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 git-gui/Makefile |   20 ++++++++++++++------
 1 files changed, 14 insertions(+), 6 deletions(-)

Show changes to git-gui/Makefile +14 −6

diff --git a/git-gui/Makefile b/git-gui/Makefile
index 3de0de1..404bff0 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -2,6 +2,12 @@ all::
 
 # Define V=1 to have a more verbose compile.
 #
+QUIET =
+QUIET_MSG = :
+ifndef V
+    QUIET = @
+    QUIET_MSG = echo '   '
+endif
 
 GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE
 	@$(SHELL_PATH) ./GIT-VERSION-GEN
@@ -109,12 +115,14 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS
 all:: $(ALL_PROGRAMS) lib/tclIndex
 
 install: all
-	$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
-	$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
-	$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
-	$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'
-	$(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'
-	$(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)
+	$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
+	$(QUIET)$(QUIET_MSG)INSTALL git-gui; $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
+	$(QUIET)$(foreach p,$(GITGUI_BUILT_INS),$(QUIET_MSG)INSTALL $p;\
+	    rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && \
+	    ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
+	$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'
+	$(QUIET)$(foreach p,lib/tclIndex $(ALL_LIBFILES), $(QUIET_MSG)INSTALL $p;\
+	    $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)
 
 dist-version:
 	@mkdir -p $(TARDIR)

-- 
1.5.2.162.g8fc0