{"thread":{"id":"8380","subject":"[PATCH] Make the installation target of git-gui a little less chatty","startedAt":"2007-05-31T22:25:27Z","lastAt":"2007-06-01T23:09:56Z","messageCount":4,"participants":["Alex Riesen","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"43698","messageId":"20070531222527.GB12204@steel.home","threadId":"8380","inReplyTo":null,"subject":"[PATCH] Make the installation target of git-gui a little less chatty","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-05-31T22:25:27Z","receivedAt":"2007-05-31T22:25:27Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n\nThe patch is hand-tuned to start in git-gui, so that it can be applied\nin git-gui repo.\n\n Makefile |   17 +++++++++++------\n 1 files changed, 11 insertions(+), 6 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 3de0de1..1eafbf8 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2,6 +2,10 @@ all::\n \n # Define V=1 to have a more verbose compile.\n #\n+QUIET =\n+ifndef V\n+    QUIET = @\n+endif\n \n GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE\n \t@$(SHELL_PATH) ./GIT-VERSION-GEN\n@@ -109,12 +113,13 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS\n all:: $(ALL_PROGRAMS) lib/tclIndex\n \n install: all\n-\t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n-\t$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n-\t$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)\n-\t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'\n-\t$(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'\n-\t$(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)\n+\t@echo installing git-gui\n+\t$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n+\t$(QUIET)$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n+\t$(QUIET)$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)\n+\t$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'\n+\t$(QUIET)$(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'\n+\t$(QUIET)$(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)\n \n dist-version:\n \t@mkdir -p $(TARDIR)\n-- \n1.5.2.162.gbaa1f\n"},{"id":"43713","messageId":"20070601030257.GX7044@spearce.org","threadId":"8380","inReplyTo":"20070531222527.GB12204@steel.home","subject":"Re: [PATCH] Make the installation target of git-gui a little less chatty","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-06-01T03:02:57Z","receivedAt":"2007-06-01T03:02:57Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Alex Riesen <raa.lkml@gmail.com> wrote:\n> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n> ---\n\nI have the exact same reaction as Junio had to the same change in\ngit.git...  I'll apply it if you resend according to his guidelines.\n \n> The patch is hand-tuned to start in git-gui, so that it can be applied\n> in git-gui repo.\n\nHand-tuning the patch isn't necessary, just making the change its\nown patch is all that is required.  Git has these nifty flags for\ngit-am like -p2 and -3 that make editing filenames in the patch\ncompletely unnecessary.  ;-)\n\n-- \nShawn.\n"},{"id":"43723","messageId":"81b0412b0706010036i3f8295fbob3dda2e82e9ef207@mail.gmail.com","threadId":"8380","inReplyTo":"20070601030257.GX7044@spearce.org","subject":"Re: [PATCH] Make the installation target of git-gui a little less chatty","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-06-01T07:36:08Z","receivedAt":"2007-06-01T07:36:08Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 6/1/07, Shawn O. Pearce <spearce@spearce.org> wrote:\n> > The patch is hand-tuned to start in git-gui, so that it can be applied\n> > in git-gui repo.\n>\n> Hand-tuning the patch isn't necessary, just making the change its\n> own patch is all that is required.  Git has these nifty flags for\n\nGood to know\n"},{"id":"43772","messageId":"20070601230956.GB6360@steel.home","threadId":"8380","inReplyTo":"20070601030257.GX7044@spearce.org","subject":"[PATCH] Make the installation target of git-gui a little less chatty","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-06-01T23:09:56Z","receivedAt":"2007-06-01T23:09:56Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n git-gui/Makefile |   20 ++++++++++++++------\n 1 files changed, 14 insertions(+), 6 deletions(-)\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex 3de0de1..404bff0 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -2,6 +2,12 @@ all::\n \n # Define V=1 to have a more verbose compile.\n #\n+QUIET =\n+QUIET_MSG = :\n+ifndef V\n+    QUIET = @\n+    QUIET_MSG = echo '   '\n+endif\n \n GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE\n \t@$(SHELL_PATH) ./GIT-VERSION-GEN\n@@ -109,12 +115,14 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS\n all:: $(ALL_PROGRAMS) lib/tclIndex\n \n install: all\n-\t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n-\t$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n-\t$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)\n-\t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'\n-\t$(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'\n-\t$(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)\n+\t$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n+\t$(QUIET)$(QUIET_MSG)INSTALL git-gui; $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n+\t$(QUIET)$(foreach p,$(GITGUI_BUILT_INS),$(QUIET_MSG)INSTALL $p;\\\n+\t    rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && \\\n+\t    ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)\n+\t$(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'\n+\t$(QUIET)$(foreach p,lib/tclIndex $(ALL_LIBFILES), $(QUIET_MSG)INSTALL $p;\\\n+\t    $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)\n \n dist-version:\n \t@mkdir -p $(TARDIR)\n-- \n1.5.2.162.g8fc0\n"}]}