# [PATCH] Make the installation target of git-gui a little less chatty 4 messages from 2007-05-31 to 2007-06-01. Participants: Alex Riesen, Shawn O. Pearce. Thread: https://gitlist.dev/t/8380 ## Alex Riesen, 2007-05-31 22:25 Subject: [PATCH] Make the installation target of git-gui a little less chatty Message-ID: <20070531222527.GB12204@steel.home> URL: https://gitlist.dev/e/20070531222527.GB12204%40steel.home ``` Signed-off-by: Alex Riesen --- The patch is hand-tuned to start in git-gui, so that it can be applied in git-gui repo. Makefile | 17 +++++++++++------ 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 3de0de1..1eafbf8 100644 --- a/Makefile +++ b/Makefile @@ -2,6 +2,10 @@ all:: # Define V=1 to have a more verbose compile. # +QUIET = +ifndef V + QUIET = @ +endif GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE @$(SHELL_PATH) ./GIT-VERSION-GEN @@ -109,12 +113,13 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS all:: $(ALL_PROGRAMS) lib/tclIndex install: all - $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)' - $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)' - $(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;) - $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)' - $(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)' - $(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;) + @echo installing git-gui + $(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)' + $(QUIET)$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)' + $(QUIET)$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;) + $(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)' + $(QUIET)$(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)' + $(QUIET)$(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;) dist-version: @mkdir -p $(TARDIR) -- 1.5.2.162.gbaa1f ``` ## Shawn O. Pearce, 2007-06-01 03:02 Subject: Re: [PATCH] Make the installation target of git-gui a little less chatty Message-ID: <20070601030257.GX7044@spearce.org> URL: https://gitlist.dev/e/20070601030257.GX7044%40spearce.org In-Reply-To: <20070531222527.GB12204@steel.home> ``` Alex Riesen wrote: > Signed-off-by: Alex Riesen > --- I have the exact same reaction as Junio had to the same change in git.git... I'll apply it if you resend according to his guidelines. > The patch is hand-tuned to start in git-gui, so that it can be applied > in git-gui repo. Hand-tuning the patch isn't necessary, just making the change its own patch is all that is required. Git has these nifty flags for git-am like -p2 and -3 that make editing filenames in the patch completely unnecessary. ;-) -- Shawn. ``` ## Alex Riesen, 2007-06-01 07:36 Subject: Re: [PATCH] Make the installation target of git-gui a little less chatty Message-ID: <81b0412b0706010036i3f8295fbob3dda2e82e9ef207@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0706010036i3f8295fbob3dda2e82e9ef207%40mail.gmail.com In-Reply-To: <20070601030257.GX7044@spearce.org> ``` On 6/1/07, Shawn O. Pearce wrote: > > The patch is hand-tuned to start in git-gui, so that it can be applied > > in git-gui repo. > > Hand-tuning the patch isn't necessary, just making the change its > own patch is all that is required. Git has these nifty flags for Good to know ``` ## Alex Riesen, 2007-06-01 23:09 Subject: [PATCH] Make the installation target of git-gui a little less chatty Message-ID: <20070601230956.GB6360@steel.home> URL: https://gitlist.dev/e/20070601230956.GB6360%40steel.home In-Reply-To: <20070601030257.GX7044@spearce.org> ``` Signed-off-by: Alex Riesen --- git-gui/Makefile | 20 ++++++++++++++------ 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/git-gui/Makefile b/git-gui/Makefile index 3de0de1..404bff0 100644 --- a/git-gui/Makefile +++ b/git-gui/Makefile @@ -2,6 +2,12 @@ all:: # Define V=1 to have a more verbose compile. # +QUIET = +QUIET_MSG = : +ifndef V + QUIET = @ + QUIET_MSG = echo ' ' +endif GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE @$(SHELL_PATH) ./GIT-VERSION-GEN @@ -109,12 +115,14 @@ GIT-GUI-VARS: .FORCE-GIT-GUI-VARS all:: $(ALL_PROGRAMS) lib/tclIndex install: all - $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)' - $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)' - $(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;) - $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)' - $(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)' - $(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;) + $(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)' + $(QUIET)$(QUIET_MSG)INSTALL git-gui; $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)' + $(QUIET)$(foreach p,$(GITGUI_BUILT_INS),$(QUIET_MSG)INSTALL $p;\ + rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && \ + ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;) + $(QUIET)$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)' + $(QUIET)$(foreach p,lib/tclIndex $(ALL_LIBFILES), $(QUIET_MSG)INSTALL $p;\ + $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;) dist-version: @mkdir -p $(TARDIR) -- 1.5.2.162.g8fc0 ```