threads / patch / 8363

patchmissing return

Subject: [PATCH] missing return

## tl;dr

3 messages between May 30, 2007 and May 30, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Jerald Fitzjerald· May 30, 2007, 12:39 UTC · lore

OK for mainline?

---

Show changes to base85.c +1 −1

diff --git a/base85.c b/base85.c
--- a/base85.c
+++ b/base85.c
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf
 		 */
 		if (0x03030303 < acc ||
 		    0xffffffff - de < (acc *= 85))
-			error("invalid base85 sequence %.5s", buffer-5);
+			return error("invalid base85 sequence %.5s", buffer-5);
 		acc += de;
 		say1(" %08x", acc);

Junio C Hamano· May 30, 2007, 17:24 UTC · re: Jerald Fitzjerald · lore

Re: [PATCH] missing return

Jerald Fitzjerald <jfj@freemail.gr> writes:

> OK for mainline?

Sure, with a signoff please.

I realize that I've seen this pointed out by somebody already. Thanks for reminder.

Jerald Fitzjerald· May 30, 2007, 19:16 UTC · re: Junio C Hamano · lore

Re: [PATCH] missing return

Junio C Hamano wrote:

>I realize that I've seen this pointed out by somebody already.
>

It was suggested on irc a couple of days ago.

Signed-off-by: Jerald Fitzjerald <jfj@freemail.gr>

---

Show changes to base85.c +1 −1

diff --git a/base85.c b/base85.c
--- a/base85.c
+++ b/base85.c
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf
		 */
		if (0x03030303 < acc ||
		    0xffffffff - de < (acc *= 85))
-			error("invalid base85 sequence %.5s", buffer-5);
+			return error("invalid base85 sequence %.5s", buffer-5);
		acc += de;
		say1(" %08x", acc);