{"thread":{"id":"8363","subject":"[PATCH] missing return","startedAt":"2007-05-30T12:39:58Z","lastAt":"2007-05-30T19:16:45Z","messageCount":3,"participants":["Jerald Fitzjerald","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"43632","messageId":"465D709E.7040402@freemail.gr","threadId":"8363","inReplyTo":null,"subject":"[PATCH] missing return","fromName":"Jerald Fitzjerald","fromEmail":"jfj@freemail.gr","sentAt":"2007-05-30T12:39:58Z","receivedAt":"2007-05-30T12:39:58Z","isPatch":true,"sender":{"key":"jfj@freemail.gr","avatar":null},"body":"OK for mainline?\n\n---\n\ndiff --git a/base85.c b/base85.c\n--- a/base85.c\n+++ b/base85.c\n@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf\n \t\t */\n \t\tif (0x03030303 < acc ||\n \t\t    0xffffffff - de < (acc *= 85))\n-\t\t\terror(\"invalid base85 sequence %.5s\", buffer-5);\n+\t\t\treturn error(\"invalid base85 sequence %.5s\", buffer-5);\n \t\tacc += de;\n \t\tsay1(\" %08x\", acc);\n \n"},{"id":"43648","messageId":"7vk5uq2pio.fsf@assigned-by-dhcp.cox.net","threadId":"8363","inReplyTo":"465D709E.7040402@freemail.gr","subject":"Re: [PATCH] missing return","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-30T17:24:31Z","receivedAt":"2007-05-30T17:24:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jerald Fitzjerald <jfj@freemail.gr> writes:\n\n> OK for mainline?\n\nSure, with a signoff please.\n\nI realize that I've seen this pointed out by somebody already.\nThanks for reminder.\n"},{"id":"43657","messageId":"465DCD9D.5090501@freemail.gr","threadId":"8363","inReplyTo":"7vk5uq2pio.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] missing return","fromName":"Jerald Fitzjerald","fromEmail":"jfj@freemail.gr","sentAt":"2007-05-30T19:16:45Z","receivedAt":"2007-05-30T19:16:45Z","isPatch":true,"sender":{"key":"jfj@freemail.gr","avatar":null},"body":"Junio C Hamano wrote:\n\n>I realize that I've seen this pointed out by somebody already.\n>\nIt was suggested on irc a couple of days ago.\n\nSigned-off-by: Jerald Fitzjerald <jfj@freemail.gr>\n\n---\n\ndiff --git a/base85.c b/base85.c\n--- a/base85.c\n+++ b/base85.c\n@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf\n\t\t */\n\t\tif (0x03030303 < acc ||\n\t\t    0xffffffff - de < (acc *= 85))\n-\t\t\terror(\"invalid base85 sequence %.5s\", buffer-5);\n+\t\t\treturn error(\"invalid base85 sequence %.5s\", buffer-5);\n\t\tacc += de;\n\t\tsay1(\" %08x\", acc);\n"}]}