# [PATCH] missing return 3 messages from 2007-05-30 to 2007-05-30. Participants: Jerald Fitzjerald, Junio C Hamano. Thread: https://gitlist.dev/t/8363 ## Jerald Fitzjerald, 2007-05-30 12:39 Subject: [PATCH] missing return Message-ID: <465D709E.7040402@freemail.gr> URL: https://gitlist.dev/e/465D709E.7040402%40freemail.gr ``` OK for mainline? --- diff --git a/base85.c b/base85.c --- a/base85.c +++ b/base85.c @@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf */ if (0x03030303 < acc || 0xffffffff - de < (acc *= 85)) - error("invalid base85 sequence %.5s", buffer-5); + return error("invalid base85 sequence %.5s", buffer-5); acc += de; say1(" %08x", acc); ``` ## Junio C Hamano, 2007-05-30 17:24 Subject: Re: [PATCH] missing return Message-ID: <7vk5uq2pio.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vk5uq2pio.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <465D709E.7040402@freemail.gr> ``` Jerald Fitzjerald writes: > OK for mainline? Sure, with a signoff please. I realize that I've seen this pointed out by somebody already. Thanks for reminder. ``` ## Jerald Fitzjerald, 2007-05-30 19:16 Subject: Re: [PATCH] missing return Message-ID: <465DCD9D.5090501@freemail.gr> URL: https://gitlist.dev/e/465DCD9D.5090501%40freemail.gr In-Reply-To: <7vk5uq2pio.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano wrote: >I realize that I've seen this pointed out by somebody already. > It was suggested on irc a couple of days ago. Signed-off-by: Jerald Fitzjerald --- diff --git a/base85.c b/base85.c --- a/base85.c +++ b/base85.c @@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf */ if (0x03030303 < acc || 0xffffffff - de < (acc *= 85)) - error("invalid base85 sequence %.5s", buffer-5); + return error("invalid base85 sequence %.5s", buffer-5); acc += de; say1(" %08x", acc); ```