[PATCH] gitk doesn't handle filenames with space correctly

Frédéric Jolliton· Apr 7, 2007, 01:22 UTC · lore

Hi,

Here is an attempt to fix gitk such that it can display filenames with space correctly, in the right column (Patch/Tree). I don't know TCL, so probably that a better solution exists.

--- gitk.orig 2007-04-07 02:36:05.000000000 +0200 +++ gitk 2007-04-07 03:13:16.000000000 +0200

Show changes to diff +2 −3

@@ -4114,8 +4114,7 @@
 
     while {[gets $gtf line] >= 0} {
 	if {[lindex $line 1] ne "blob"} continue
-	set sha1 [lindex $line 2]
-	set fname [lindex $line 3]
+	regexp {^[^ ]+ [^ ]+ ([^ ]+)\t(.*)} $line -> sha1 fname
 	lappend treefilelist($id) $fname
 	lappend treeidlist($id) $sha1
     }
@@ -4324,7 +4323,7 @@
 	}
 	return
     }
-    set file [lindex $line 5]
+    regexp {^[^ ]+ [^ ]+ [^ ]+ [^ ]+ [^ ]+\t(.*)} $line -> file
     lappend treediff $file
 }

-- 
Frédéric Jolliton

Bernt Hansen· Apr 12, 2007, 00:00 UTC · re: Frédéric Jolliton · lore

Re: [PATCH] gitk doesn't handle filenames with space correctly

Frédéric Jolliton <gmane@frederic.jolliton.com> writes:

> Here is an attempt to fix gitk such that it can display filenames with
> space correctly, in the right column (Patch/Tree). I don't know TCL, so
> probably that a better solution exists.

Thanks Frédéric!

This patch works great for me.

:)

Bernt

patchgitk doesn't handle filenames with space correctly