# [PATCH] gitk doesn't handle filenames with space correctly

2 messages from 2007-04-07 to 2007-04-12. Participants: Frédéric Jolliton, Bernt Hansen.
Thread: https://gitlist.dev/t/7553

## Frédéric Jolliton, 2007-04-07 01:22

Subject: [PATCH] gitk doesn't handle filenames with space correctly
Message-ID: <86slbd6kr0.fsf@mau.intra.tuxee.net>
URL: https://gitlist.dev/e/86slbd6kr0.fsf%40mau.intra.tuxee.net

```
Hi,

Here is an attempt to fix gitk such that it can display filenames with
space correctly, in the right column (Patch/Tree). I don't know TCL, so
probably that a better solution exists.

--- gitk.orig	2007-04-07 02:36:05.000000000 +0200
+++ gitk	2007-04-07 03:13:16.000000000 +0200
@@ -4114,8 +4114,7 @@
 
     while {[gets $gtf line] >= 0} {
 	if {[lindex $line 1] ne "blob"} continue
-	set sha1 [lindex $line 2]
-	set fname [lindex $line 3]
+	regexp {^[^ ]+ [^ ]+ ([^ ]+)\t(.*)} $line -> sha1 fname
 	lappend treefilelist($id) $fname
 	lappend treeidlist($id) $sha1
     }
@@ -4324,7 +4323,7 @@
 	}
 	return
     }
-    set file [lindex $line 5]
+    regexp {^[^ ]+ [^ ]+ [^ ]+ [^ ]+ [^ ]+\t(.*)} $line -> file
     lappend treediff $file
 }

-- 
Frédéric Jolliton

```

## Bernt Hansen, 2007-04-12 00:00

Subject: Re: [PATCH] gitk doesn't handle filenames with space correctly
Message-ID: <87fy76h37b.fsf@gollum.intra.norang.ca>
URL: https://gitlist.dev/e/87fy76h37b.fsf%40gollum.intra.norang.ca
In-Reply-To: <86slbd6kr0.fsf@mau.intra.tuxee.net>

```
Frédéric Jolliton <gmane@frederic.jolliton.com> writes:

> Here is an attempt to fix gitk such that it can display filenames with
> space correctly, in the right column (Patch/Tree). I don't know TCL, so
> probably that a better solution exists.

Thanks Frédéric!

This patch works great for me.

:)

Bernt

```