{"thread":{"id":"7553","subject":"[PATCH] gitk doesn't handle filenames with space correctly","startedAt":"2007-04-07T01:22:59Z","lastAt":"2007-04-12T00:00:08Z","messageCount":2,"participants":["Frédéric Jolliton","Bernt Hansen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38833","messageId":"86slbd6kr0.fsf@mau.intra.tuxee.net","threadId":"7553","inReplyTo":null,"subject":"[PATCH] gitk doesn't handle filenames with space correctly","fromName":"Frédéric Jolliton","fromEmail":"gmane@frederic.jolliton.com","sentAt":"2007-04-07T01:22:59Z","receivedAt":"2007-04-07T01:22:59Z","isPatch":true,"sender":{"key":"gmane@frederic.jolliton.com","avatar":null},"body":"Hi,\n\nHere is an attempt to fix gitk such that it can display filenames with\nspace correctly, in the right column (Patch/Tree). I don't know TCL, so\nprobably that a better solution exists.\n\n--- gitk.orig\t2007-04-07 02:36:05.000000000 +0200\n+++ gitk\t2007-04-07 03:13:16.000000000 +0200\n@@ -4114,8 +4114,7 @@\n \n     while {[gets $gtf line] >= 0} {\n \tif {[lindex $line 1] ne \"blob\"} continue\n-\tset sha1 [lindex $line 2]\n-\tset fname [lindex $line 3]\n+\tregexp {^[^ ]+ [^ ]+ ([^ ]+)\\t(.*)} $line -> sha1 fname\n \tlappend treefilelist($id) $fname\n \tlappend treeidlist($id) $sha1\n     }\n@@ -4324,7 +4323,7 @@\n \t}\n \treturn\n     }\n-    set file [lindex $line 5]\n+    regexp {^[^ ]+ [^ ]+ [^ ]+ [^ ]+ [^ ]+\\t(.*)} $line -> file\n     lappend treediff $file\n }\n\n-- \nFrédéric Jolliton\n"},{"id":"39162","messageId":"87fy76h37b.fsf@gollum.intra.norang.ca","threadId":"7553","inReplyTo":"86slbd6kr0.fsf@mau.intra.tuxee.net","subject":"Re: [PATCH] gitk doesn't handle filenames with space correctly","fromName":"Bernt Hansen","fromEmail":"bernt@norang.ca","sentAt":"2007-04-12T00:00:08Z","receivedAt":"2007-04-12T00:00:08Z","isPatch":true,"sender":{"key":"bernt@norang.ca","avatar":null},"body":"Frédéric Jolliton <gmane@frederic.jolliton.com> writes:\n\n> Here is an attempt to fix gitk such that it can display filenames with\n> space correctly, in the right column (Patch/Tree). I don't know TCL, so\n> probably that a better solution exists.\n\nThanks Frédéric!\n\nThis patch works great for me.\n\n:)\n\nBernt\n"}]}