threads / patch / 7519

patchFix passing of TCLTK_PATH to git-gui

Subject: [PATCH] Fix passing of TCLTK_PATH to git-gui

## tl;dr

4 messages between Apr 5, 2007 and Apr 5, 2007. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Alex Riesen· Apr 5, 2007, 07:49 UTC · lore
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

GNU make does not include environment variables by default in its namespace.

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
From 1df61a9f1f3551eaad699ce1c4ef4ada734c9836 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 5 Apr 2007 09:45:03 +0200
Subject: [PATCH] Fix passing of TCLTK_PATH to git-gui
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to Makefile +1 −1
diff --git a/Makefile b/Makefile
index ad321b3..507ad91 100644
--- a/Makefile
+++ b/Makefile
@@ -703,7 +703,7 @@ endif
 
 all::
 ifndef NO_TCLTK
-	$(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all
+	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all
 endif
 	$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all
 	$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1)

-- 
1.5.1.41.g3ea92
Junio C Hamano· Apr 5, 2007, 08:44 UTC · re: Alex Riesen · lore

Re: [PATCH] Fix passing of TCLTK_PATH to git-gui

"Alex Riesen" <raa.lkml@gmail.com> writes:
Show 5 quoted lines
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> GNU make does not include environment variables by default
> in its namespace.
Shouldn't this be part of proposed commit log message?

Also I'd appreciate if you did not attach the format-patch output, but send a properly formatted e-mail. I would not be so picky to non-regulars, but I expect I'd be getting many more patches from you, so...

Alex Riesen· Apr 5, 2007, 13:10 UTC · re: Junio C Hamano · lore

Re: [PATCH] Fix passing of TCLTK_PATH to git-gui

On 4/5/07, Junio C Hamano <junkio@cox.net> wrote:
Show 9 quoted lines
> "Alex Riesen" <raa.lkml@gmail.com> writes:
>
> > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> > ---
> >
> > GNU make does not include environment variables by default
> > in its namespace.
>
> Shouldn't this be part of proposed commit log message?
Err... yes.
> Also I'd appreciate if you did not attach the format-patch
> output, but send a properly formatted e-mail.  I would not be so
> picky to non-regulars, but I expect I'd be getting many more
> patches from you, so...
I'll resend as soon as I get home.
Alex Riesen· Apr 5, 2007, 19:31 UTC · re: Alex Riesen · lore

GNU make does not include environment variables by default in its namespace. Just pass them in make command line.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to Makefile +1 −1
diff --git a/Makefile b/Makefile
index ad321b3..507ad91 100644
--- a/Makefile
+++ b/Makefile
@@ -703,7 +703,7 @@ endif
 
 all::
 ifndef NO_TCLTK
-	$(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all
+	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all
 endif
 	$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all
 	$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1)

-- 
1.5.1.rc3.48.g803f1

← back to recent threads