# [PATCH] Fix passing of TCLTK_PATH to git-gui 4 messages from 2007-04-05 to 2007-04-05. Participants: Alex Riesen, Junio C Hamano. Thread: https://gitlist.dev/t/7519 ## Alex Riesen, 2007-04-05 07:49 Subject: [PATCH] Fix passing of TCLTK_PATH to git-gui Message-ID: <81b0412b0704050049u746842ebn270998c5732927d3@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0704050049u746842ebn270998c5732927d3%40mail.gmail.com ``` Signed-off-by: Alex Riesen --- GNU make does not include environment variables by default in its namespace. Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) From 1df61a9f1f3551eaad699ce1c4ef4ada734c9836 Mon Sep 17 00:00:00 2001 From: Alex Riesen Date: Thu, 5 Apr 2007 09:45:03 +0200 Subject: [PATCH] Fix passing of TCLTK_PATH to git-gui Signed-off-by: Alex Riesen --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index ad321b3..507ad91 100644 --- a/Makefile +++ b/Makefile @@ -703,7 +703,7 @@ endif all:: ifndef NO_TCLTK - $(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all + $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all endif $(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all $(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1) -- 1.5.1.41.g3ea92 ``` ## Junio C Hamano, 2007-04-05 08:44 Subject: Re: [PATCH] Fix passing of TCLTK_PATH to git-gui Message-ID: <7v8xd7tdl0.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v8xd7tdl0.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <81b0412b0704050049u746842ebn270998c5732927d3@mail.gmail.com> ``` "Alex Riesen" writes: > Signed-off-by: Alex Riesen > --- > > GNU make does not include environment variables by default > in its namespace. Shouldn't this be part of proposed commit log message? Also I'd appreciate if you did not attach the format-patch output, but send a properly formatted e-mail. I would not be so picky to non-regulars, but I expect I'd be getting many more patches from you, so... ``` ## Alex Riesen, 2007-04-05 13:10 Subject: Re: [PATCH] Fix passing of TCLTK_PATH to git-gui Message-ID: <81b0412b0704050610m19a72984u34888af00d70eeab@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0704050610m19a72984u34888af00d70eeab%40mail.gmail.com In-Reply-To: <7v8xd7tdl0.fsf@assigned-by-dhcp.cox.net> ``` On 4/5/07, Junio C Hamano wrote: > "Alex Riesen" writes: > > > Signed-off-by: Alex Riesen > > --- > > > > GNU make does not include environment variables by default > > in its namespace. > > Shouldn't this be part of proposed commit log message? Err... yes. > Also I'd appreciate if you did not attach the format-patch > output, but send a properly formatted e-mail. I would not be so > picky to non-regulars, but I expect I'd be getting many more > patches from you, so... I'll resend as soon as I get home. ``` ## Alex Riesen, 2007-04-05 19:31 Subject: [PATCH] Fix passing of TCLTK_PATH to git-gui Message-ID: <20070405193153.GA15907@steel.home> URL: https://gitlist.dev/e/20070405193153.GA15907%40steel.home In-Reply-To: <81b0412b0704050610m19a72984u34888af00d70eeab@mail.gmail.com> ``` GNU make does not include environment variables by default in its namespace. Just pass them in make command line. Signed-off-by: Alex Riesen --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index ad321b3..507ad91 100644 --- a/Makefile +++ b/Makefile @@ -703,7 +703,7 @@ endif all:: ifndef NO_TCLTK - $(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all + $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all endif $(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all $(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1) -- 1.5.1.rc3.48.g803f1 ```