{"thread":{"id":"7519","subject":"[PATCH] Fix passing of TCLTK_PATH to git-gui","startedAt":"2007-04-05T07:49:57Z","lastAt":"2007-04-05T19:31:53Z","messageCount":4,"participants":["Alex Riesen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38682","messageId":"81b0412b0704050049u746842ebn270998c5732927d3@mail.gmail.com","threadId":"7519","inReplyTo":null,"subject":"[PATCH] Fix passing of TCLTK_PATH to git-gui","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-04-05T07:49:57Z","receivedAt":"2007-04-05T07:49:57Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n\nGNU make does not include environment variables by default\nin its namespace.\n\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n\nFrom 1df61a9f1f3551eaad699ce1c4ef4ada734c9836 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen <raa.lkml@gmail.com>\nDate: Thu, 5 Apr 2007 09:45:03 +0200\nSubject: [PATCH] Fix passing of TCLTK_PATH to git-gui\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex ad321b3..507ad91 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -703,7 +703,7 @@ endif\n \n all::\n ifndef NO_TCLTK\n-\t$(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all\n+\t$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all\n endif\n \t$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all\n \t$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1)\n-- \n1.5.1.41.g3ea92\n\n"},{"id":"38688","messageId":"7v8xd7tdl0.fsf@assigned-by-dhcp.cox.net","threadId":"7519","inReplyTo":"81b0412b0704050049u746842ebn270998c5732927d3@mail.gmail.com","subject":"Re: [PATCH] Fix passing of TCLTK_PATH to git-gui","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-05T08:44:43Z","receivedAt":"2007-04-05T08:44:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Alex Riesen\" <raa.lkml@gmail.com> writes:\n\n> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n> ---\n>\n> GNU make does not include environment variables by default\n> in its namespace.\n\nShouldn't this be part of proposed commit log message?\n\nAlso I'd appreciate if you did not attach the format-patch\noutput, but send a properly formatted e-mail.  I would not be so\npicky to non-regulars, but I expect I'd be getting many more\npatches from you, so...\n"},{"id":"38702","messageId":"81b0412b0704050610m19a72984u34888af00d70eeab@mail.gmail.com","threadId":"7519","inReplyTo":"7v8xd7tdl0.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix passing of TCLTK_PATH to git-gui","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-04-05T13:10:25Z","receivedAt":"2007-04-05T13:10:25Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 4/5/07, Junio C Hamano <junkio@cox.net> wrote:\n> \"Alex Riesen\" <raa.lkml@gmail.com> writes:\n>\n> > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n> > ---\n> >\n> > GNU make does not include environment variables by default\n> > in its namespace.\n>\n> Shouldn't this be part of proposed commit log message?\n\nErr... yes.\n\n> Also I'd appreciate if you did not attach the format-patch\n> output, but send a properly formatted e-mail.  I would not be so\n> picky to non-regulars, but I expect I'd be getting many more\n> patches from you, so...\n\nI'll resend as soon as I get home.\n"},{"id":"38727","messageId":"20070405193153.GA15907@steel.home","threadId":"7519","inReplyTo":"81b0412b0704050610m19a72984u34888af00d70eeab@mail.gmail.com","subject":"[PATCH] Fix passing of TCLTK_PATH to git-gui","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-04-05T19:31:53Z","receivedAt":"2007-04-05T19:31:53Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"GNU make does not include environment variables by default\nin its namespace. Just pass them in make command line.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex ad321b3..507ad91 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -703,7 +703,7 @@ endif\n \n all::\n ifndef NO_TCLTK\n-\t$(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all\n+\t$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all\n endif\n \t$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all\n \t$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1)\n-- \n1.5.1.rc3.48.g803f1\n"}]}