threads / discuss / 727

BEWARE: mkdelta is broken

Subject: BEWARE: mkdelta is broken

## tl;dr

4 messages between May 27, 2005 and May 27, 2005.

replies: 3people: 2as markdown or json

Nicolas Pitre· May 27, 2005, 01:32 UTC · lore

Please don't use mkdelta on a valuable repository for the time being.

The current delta loop detection logic is broken. So if you have multiple merged branches or you have a changeset that revert things then you might end up with a delta loop and fsck-cache will effectively complain about unresolved deltas and assorted dangling/broken object links.

I'm working on a fix right now.

Nicolas

Thomas Glanzmann· May 27, 2005, 09:41 UTC · re: Nicolas Pitre · lore

Re: BEWARE: mkdelta is broken

Hello,

Show 5 quoted lines

> The current delta loop detection logic is broken.  So if you have 
> multiple merged branches or you have a changeset that revert things then 
> you might end up with a delta loop and fsck-cache will effectively 
> complain about unresolved deltas and assorted dangling/broken object 
> links.

I wanted to give you heads-up, but I forgot it. But I think noone is using it at the moment otherwise they had complained in the first place.

However ... I took linux-2.6 repository. Ran git-deltafy-script && git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs import.

	Thomas

Nicolas Pitre· May 27, 2005, 17:37 UTC · re: Thomas Glanzmann · lore

Re: BEWARE: mkdelta is broken

On Fri, 27 May 2005, Thomas Glanzmann wrote:

Show 14 quoted lines

> Hello,
> 
> > The current delta loop detection logic is broken.  So if you have 
> > multiple merged branches or you have a changeset that revert things then 
> > you might end up with a delta loop and fsck-cache will effectively 
> > complain about unresolved deltas and assorted dangling/broken object 
> > links.
> 
> I wanted to give you heads-up, but I forgot it. But I think noone is
> using it at the moment otherwise they had complained in the first place.
> 
> However ... I took linux-2.6 repository. Ran git-deltafy-script &&
> git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs
> import.

Yes, that's because you end up with delta loops. When trying to expand the delta, it keeps looping and allocating memory until killed.

I fixed that already and am preparing a patch at the moment.

Nicolas

Thomas Glanzmann· May 27, 2005, 17:42 UTC · re: Nicolas Pitre · lore

Re: BEWARE: mkdelta is broken

Hello,

> Yes, that's because you end up with delta loops.  When trying to expand 
> the delta, it keeps looping and allocating memory until killed.

> I fixed that already and am preparing a patch at the moment.

perfekt. I am happy to give it a test.

	Thomas