# BEWARE: mkdelta is broken 4 messages from 2005-05-27 to 2005-05-27. Participants: Nicolas Pitre, Thomas Glanzmann. Thread: https://gitlist.dev/t/727 ## Nicolas Pitre, 2005-05-27 01:32 Subject: BEWARE: mkdelta is broken Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.62.0505262125050.16151%40localhost.localdomain ``` Please don't use mkdelta on a valuable repository for the time being. The current delta loop detection logic is broken. So if you have multiple merged branches or you have a changeset that revert things then you might end up with a delta loop and fsck-cache will effectively complain about unresolved deltas and assorted dangling/broken object links. I'm working on a fix right now. Nicolas ``` ## Thomas Glanzmann, 2005-05-27 09:41 Subject: Re: BEWARE: mkdelta is broken Message-ID: <20050527094133.GR24351@cip.informatik.uni-erlangen.de> URL: https://gitlist.dev/e/20050527094133.GR24351%40cip.informatik.uni-erlangen.de In-Reply-To: ``` Hello, > The current delta loop detection logic is broken. So if you have > multiple merged branches or you have a changeset that revert things then > you might end up with a delta loop and fsck-cache will effectively > complain about unresolved deltas and assorted dangling/broken object > links. I wanted to give you heads-up, but I forgot it. But I think noone is using it at the moment otherwise they had complained in the first place. However ... I took linux-2.6 repository. Ran git-deltafy-script && git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs import. Thomas ``` ## Nicolas Pitre, 2005-05-27 17:37 Subject: Re: BEWARE: mkdelta is broken Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.62.0505271335170.16151%40localhost.localdomain In-Reply-To: <20050527094133.GR24351@cip.informatik.uni-erlangen.de> ``` On Fri, 27 May 2005, Thomas Glanzmann wrote: > Hello, > > > The current delta loop detection logic is broken. So if you have > > multiple merged branches or you have a changeset that revert things then > > you might end up with a delta loop and fsck-cache will effectively > > complain about unresolved deltas and assorted dangling/broken object > > links. > > I wanted to give you heads-up, but I forgot it. But I think noone is > using it at the moment otherwise they had complained in the first place. > > However ... I took linux-2.6 repository. Ran git-deltafy-script && > git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs > import. Yes, that's because you end up with delta loops. When trying to expand the delta, it keeps looping and allocating memory until killed. I fixed that already and am preparing a patch at the moment. Nicolas ``` ## Thomas Glanzmann, 2005-05-27 17:42 Subject: Re: BEWARE: mkdelta is broken Message-ID: <20050527174220.GB7068@cip.informatik.uni-erlangen.de> URL: https://gitlist.dev/e/20050527174220.GB7068%40cip.informatik.uni-erlangen.de In-Reply-To: ``` Hello, > Yes, that's because you end up with delta loops. When trying to expand > the delta, it keeps looping and allocating memory until killed. > I fixed that already and am preparing a patch at the moment. perfekt. I am happy to give it a test. Thomas ```