{"thread":{"id":"727","subject":"BEWARE: mkdelta is broken","startedAt":"2005-05-27T01:32:19Z","lastAt":"2005-05-27T17:42:20Z","messageCount":4,"participants":["Nicolas Pitre","Thomas Glanzmann"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"4022","messageId":"Pine.LNX.4.62.0505262125050.16151@localhost.localdomain","threadId":"727","inReplyTo":null,"subject":"BEWARE: mkdelta is broken","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2005-05-27T01:32:19Z","receivedAt":"2005-05-27T01:32:19Z","isPatch":false,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"Please don't use mkdelta on a valuable repository for the time being.\n\nThe current delta loop detection logic is broken.  So if you have \nmultiple merged branches or you have a changeset that revert things then \nyou might end up with a delta loop and fsck-cache will effectively \ncomplain about unresolved deltas and assorted dangling/broken object \nlinks.\n\nI'm working on a fix right now.\n\n\nNicolas\n"},{"id":"4040","messageId":"20050527094133.GR24351@cip.informatik.uni-erlangen.de","threadId":"727","inReplyTo":"Pine.LNX.4.62.0505262125050.16151@localhost.localdomain","subject":"Re: BEWARE: mkdelta is broken","fromName":"Thomas Glanzmann","fromEmail":"sithglan@stud.uni-erlangen.de","sentAt":"2005-05-27T09:41:33Z","receivedAt":"2005-05-27T09:41:33Z","isPatch":false,"sender":{"key":"sithglan@stud.uni-erlangen.de","avatar":null},"body":"Hello,\n\n> The current delta loop detection logic is broken.  So if you have \n> multiple merged branches or you have a changeset that revert things then \n> you might end up with a delta loop and fsck-cache will effectively \n> complain about unresolved deltas and assorted dangling/broken object \n> links.\n\nI wanted to give you heads-up, but I forgot it. But I think noone is\nusing it at the moment otherwise they had complained in the first place.\n\nHowever ... I took linux-2.6 repository. Ran git-deltafy-script &&\ngit-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs\nimport.\n\n\tThomas\n"},{"id":"4058","messageId":"Pine.LNX.4.62.0505271335170.16151@localhost.localdomain","threadId":"727","inReplyTo":"20050527094133.GR24351@cip.informatik.uni-erlangen.de","subject":"Re: BEWARE: mkdelta is broken","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2005-05-27T17:37:37Z","receivedAt":"2005-05-27T17:37:37Z","isPatch":false,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Fri, 27 May 2005, Thomas Glanzmann wrote:\n\n> Hello,\n> \n> > The current delta loop detection logic is broken.  So if you have \n> > multiple merged branches or you have a changeset that revert things then \n> > you might end up with a delta loop and fsck-cache will effectively \n> > complain about unresolved deltas and assorted dangling/broken object \n> > links.\n> \n> I wanted to give you heads-up, but I forgot it. But I think noone is\n> using it at the moment otherwise they had complained in the first place.\n> \n> However ... I took linux-2.6 repository. Ran git-deltafy-script &&\n> git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs\n> import.\n\nYes, that's because you end up with delta loops.  When trying to expand \nthe delta, it keeps looping and allocating memory until killed.\n\nI fixed that already and am preparing a patch at the moment.\n\n\nNicolas\n"},{"id":"4060","messageId":"20050527174220.GB7068@cip.informatik.uni-erlangen.de","threadId":"727","inReplyTo":"Pine.LNX.4.62.0505271335170.16151@localhost.localdomain","subject":"Re: BEWARE: mkdelta is broken","fromName":"Thomas Glanzmann","fromEmail":"sithglan@stud.uni-erlangen.de","sentAt":"2005-05-27T17:42:20Z","receivedAt":"2005-05-27T17:42:20Z","isPatch":false,"sender":{"key":"sithglan@stud.uni-erlangen.de","avatar":null},"body":"Hello,\n\n> Yes, that's because you end up with delta loops.  When trying to expand \n> the delta, it keeps looping and allocating memory until killed.\n\n> I fixed that already and am preparing a patch at the moment.\n\nperfekt. I am happy to give it a test.\n\n\tThomas\n"}]}