[PATCH 1/7] Fix t5510-fetch's use of sed

Shawn O. Pearce· Mar 12, 2007, 22:59 UTC · lore

POSIX says sed may add a trailing LF if there isn't already one there. We shouldn't rely on it not adding that LF, as some systems (Mac OS X for example) will add it.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t5510-fetch.sh |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

Show changes to t/t5510-fetch.sh +7 −1

diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index ee3f397..426017e 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -134,7 +134,13 @@ test_expect_success 'bundle does not prerequisite objects' '
 	git add file2 &&
 	git commit -m add.file2 file2 &&
 	git bundle create bundle3 -1 HEAD &&
-	sed "1,4d" < bundle3 > bundle.pack &&
+	(
+		while read x && test -n "$x"
+		do
+			:;
+		done
+		cat
+	) <bundle3 >bundle.pack &&
 	git index-pack bundle.pack &&
 	test 4 = $(git verify-pack -v bundle.pack | wc -l)
 '

-- 
1.5.0.3.985.gcf0b4

Johannes Schindelin· Mar 12, 2007, 23:06 UTC · re: Shawn O. Pearce · lore

Re: [PATCH 1/7] Fix t5510-fetch's use of sed

Hi,

On Mon, 12 Mar 2007, Shawn O. Pearce wrote:

Show 5 quoted lines

> POSIX says sed may add a trailing LF if there isn't already
> one there.  We shouldn't rely on it not adding that LF, as
> some systems (Mac OS X for example) will add it.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

ACK!

Ciao, Dscho

patch, 7 partsFix t5510-fetch's use of sed