{"thread":{"id":"7219","subject":"[PATCH 1/7] Fix t5510-fetch's use of sed","startedAt":"2007-03-12T22:59:16Z","lastAt":"2007-03-12T23:06:55Z","messageCount":2,"participants":["Shawn O. Pearce","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":7},"messages":[{"id":"36965","messageId":"20070312225916.GA16840@spearce.org","threadId":"7219","inReplyTo":null,"subject":"[PATCH 1/7] Fix t5510-fetch's use of sed","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-03-12T22:59:16Z","receivedAt":"2007-03-12T22:59:16Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"POSIX says sed may add a trailing LF if there isn't already\none there.  We shouldn't rely on it not adding that LF, as\nsome systems (Mac OS X for example) will add it.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n t/t5510-fetch.sh |    8 +++++++-\n 1 files changed, 7 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh\nindex ee3f397..426017e 100755\n--- a/t/t5510-fetch.sh\n+++ b/t/t5510-fetch.sh\n@@ -134,7 +134,13 @@ test_expect_success 'bundle does not prerequisite objects' '\n \tgit add file2 &&\n \tgit commit -m add.file2 file2 &&\n \tgit bundle create bundle3 -1 HEAD &&\n-\tsed \"1,4d\" < bundle3 > bundle.pack &&\n+\t(\n+\t\twhile read x && test -n \"$x\"\n+\t\tdo\n+\t\t\t:;\n+\t\tdone\n+\t\tcat\n+\t) <bundle3 >bundle.pack &&\n \tgit index-pack bundle.pack &&\n \ttest 4 = $(git verify-pack -v bundle.pack | wc -l)\n '\n-- \n1.5.0.3.985.gcf0b4\n"},{"id":"36972","messageId":"Pine.LNX.4.63.0703130006370.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7219","inReplyTo":"20070312225916.GA16840@spearce.org","subject":"Re: [PATCH 1/7] Fix t5510-fetch's use of sed","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-03-12T23:06:55Z","receivedAt":"2007-03-12T23:06:55Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 12 Mar 2007, Shawn O. Pearce wrote:\n\n> POSIX says sed may add a trailing LF if there isn't already\n> one there.  We shouldn't rely on it not adding that LF, as\n> some systems (Mac OS X for example) will add it.\n> \n> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>\n\nACK!\n\nCiao,\nDscho\n"}]}