# [PATCH 1/7] Fix t5510-fetch's use of sed

2 messages from 2007-03-12 to 2007-03-12. Participants: Shawn O. Pearce, Johannes Schindelin.
Thread: https://gitlist.dev/t/7219

## Shawn O. Pearce, 2007-03-12 22:59

Subject: [PATCH 1/7] Fix t5510-fetch's use of sed
Message-ID: <20070312225916.GA16840@spearce.org>
URL: https://gitlist.dev/e/20070312225916.GA16840%40spearce.org

```
POSIX says sed may add a trailing LF if there isn't already
one there.  We shouldn't rely on it not adding that LF, as
some systems (Mac OS X for example) will add it.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t5510-fetch.sh |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index ee3f397..426017e 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -134,7 +134,13 @@ test_expect_success 'bundle does not prerequisite objects' '
 	git add file2 &&
 	git commit -m add.file2 file2 &&
 	git bundle create bundle3 -1 HEAD &&
-	sed "1,4d" < bundle3 > bundle.pack &&
+	(
+		while read x && test -n "$x"
+		do
+			:;
+		done
+		cat
+	) <bundle3 >bundle.pack &&
 	git index-pack bundle.pack &&
 	test 4 = $(git verify-pack -v bundle.pack | wc -l)
 '
-- 
1.5.0.3.985.gcf0b4

```

## Johannes Schindelin, 2007-03-12 23:06

Subject: Re: [PATCH 1/7] Fix t5510-fetch's use of sed
Message-ID: <Pine.LNX.4.63.0703130006370.22628@wbgn013.biozentrum.uni-wuerzburg.de>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0703130006370.22628%40wbgn013.biozentrum.uni-wuerzburg.de
In-Reply-To: <20070312225916.GA16840@spearce.org>

```
Hi,

On Mon, 12 Mar 2007, Shawn O. Pearce wrote:

> POSIX says sed may add a trailing LF if there isn't already
> one there.  We shouldn't rely on it not adding that LF, as
> some systems (Mac OS X for example) will add it.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

ACK!

Ciao,
Dscho

```