threads / patch / 7089

patchUse non-interactive function to byte-compile files

Subject: [PATCH] Use non-interactive function to byte-compile files

## tl;dr

8 messages between Mar 5, 2007 and Mar 5, 2007. Diffs are folded; open one to read it.

replies: 7people: 5as markdown or json

Xavier Maillard· Mar 5, 2007, 08:23 UTC · lore
Hi,

Ihope this one is more closed to what you expect to see in a commit log.

* contrib/emacs/Makefile: add git-blame as a candidate to the
   	    byte-compilation.  batch-byte-compile is the prefered way
   	    to byte-compile files in batch mode. Use it instead of the
   	    interactive function.
Signed-off-by: Xavier Maillard <zedek@gnu.org>
---
 contrib/emacs/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to contrib/emacs/Makefile +2 −2
diff --git a/contrib/emacs/Makefile b/contrib/emacs/Makefile
index 350846d..8554e39 100644
--- a/contrib/emacs/Makefile
+++ b/contrib/emacs/Makefile
@@ -2,7 +2,7 @@
 
 EMACS = emacs
 
-ELC = git.elc vc-git.elc
+ELC = git.elc vc-git.elc git-blame.elc
 INSTALL ?= install
 INSTALL_ELC = $(INSTALL) -m 644
 prefix ?= $(HOME)
@@ -15,6 +15,6 @@ install: all
 	$(INSTALL_ELC) $(ELC) $(emacsdir)
 
 %.elc: %.el
-	$(EMACS) --batch --eval '(byte-compile-file "$<")'
+	$(EMACS) -batch -f batch-byte-compile $<
 
 clean:; rm -f $(ELC)

-- 
1.5.0
Karl Hasselström· Mar 5, 2007, 09:51 UTC · re: Xavier Maillard · lore

Re: [PATCH] Use non-interactive function to byte-compile files

On 2007-03-05 09:23:42 +0100, Xavier Maillard wrote:
Show 16 quoted lines
> Hi,
>
> Ihope this one is more closed to what you expect to see in a
> commit log.
>
> * contrib/emacs/Makefile: add git-blame as a candidate to the
>    	    byte-compilation.  batch-byte-compile is the prefered way
>    	    to byte-compile files in batch mode. Use it instead of the
>    	    interactive function.
>
> Signed-off-by: Xavier Maillard <zedek@gnu.org>
> ---
>  contrib/emacs/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/emacs/Makefile b/contrib/emacs/Makefile

Unless you intended the "hi, I hope this is better" part to be part of the commit message, you should put it after the "---"; otherwise, Junio will have to fix it up by hand.

Yes, Documentation/SubmittingPatches is a loooong text ...
-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Johannes Schindelin· Mar 5, 2007, 14:54 UTC · re: Karl Hasselström · lore

Re: [PATCH] Use non-interactive function to byte-compile files

Hi,
On Mon, 5 Mar 2007, Karl Hasselström wrote:
> Yes, Documentation/SubmittingPatches is a loooong text ...
Unless you count all the MUA specific things, it is just 162 lines...

Ciao, Dscho

Karl Hasselström· Mar 5, 2007, 15:04 UTC · re: Johannes Schindelin · lore

Re: [PATCH] Use non-interactive function to byte-compile files

On 2007-03-05 15:54:46 +0100, Johannes Schindelin wrote:
Show 6 quoted lines
> On Mon, 5 Mar 2007, Karl Hasselström wrote:
>
> > Yes, Documentation/SubmittingPatches is a loooong text ...
>
> Unless you count all the MUA specific things, it is just 162
> lines...

There's still a lot of information in there. It's not hard to forget one out of the ~28 paragraphs of non-MUA-specific info.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Johannes Schindelin· Mar 5, 2007, 15:37 UTC · re: Karl Hasselström · lore

[PATCH] Begin SubmittingPatches with a check list

It seems that some people prefer a short list to a long text. But even for the latter group, a quick reminder list is useful. So, add a check list to Documentation/SubmittingPatches of what to do to get your patch accepted.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
	On Mon, 5 Mar 2007, Karl Hasselström wrote:
	> On 2007-03-05 15:54:46 +0100, Johannes Schindelin wrote:
	> 
	> > On Mon, 5 Mar 2007, Karl Hasselström wrote:
	> >
	> > > Yes, Documentation/SubmittingPatches is a loooong text ...
	> >
	> > Unless you count all the MUA specific things, it is just 162
	> > lines...
	> 
	> There's still a lot of information in there. It's not hard to 
	> forget one out of the ~28 paragraphs of non-MUA-specific info.
 Documentation/SubmittingPatches |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)
Show changes to Documentation/SubmittingPatches +25 −0
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 285781d..b6b3dd5 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -1,3 +1,28 @@
+Short version for the impatient:
+
+	- make commits of logical units
+	- check for unnecessary whitespace with "git diff --check"
+	  before committing
+	- do not check in commented out code or unneeded files
+	- provide a meaningful commit message
+	- the first line of the commit message should be a short
+	  description and should skip the full stop
+	- if you want your work included in git.git, add a
+	  "Signed-off-by: Your Name <your@email.com>" line to the
+	  commit message (or just use the option "-s" when
+	  committing) to confirm that you agree to the Developer's
+	  Certificate of Origin
+	- do not PGP sign your patch
+	- use "git format-patch -M" to create the patch
+	- do not attach your patch, but paste it in the mail
+	  mail body, unless you cannot teach your mailer to
+	  leave the formatting of the patch alone
+	- provide additional information (which is unsuitable for
+	  the commit message) between the "---" and the diffstat
+	- send the patch to the list _and_ the maintainer
+
+Long version:
+
 I started reading over the SubmittingPatches document for Linux
 kernel, primarily because I wanted to have a document similar to
 it for the core GIT to make sure people understand what they are
Alex Riesen· Mar 5, 2007, 17:28 UTC · re: Johannes Schindelin · lore

Re: [PATCH] Begin SubmittingPatches with a check list

On 3/5/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> +       - do not attach your patch, but paste it in the mail
> +         mail body, unless you cannot teach your mailer to
> +         leave the formatting of the patch alone
"mail" twice in the first and seconf line
Brian Gernhardt· Mar 5, 2007, 20:52 UTC · re: Johannes Schindelin · lore

Re: [PATCH] Begin SubmittingPatches with a check list

On Mar 5, 2007, at 10:37 AM, Johannes Schindelin wrote:
> +	- use "git format-patch -M" to create the patch

The docco for git-format-patch doesn't list -M as one of it's options. Is this one of the diff-options, and does it take all of the options git-diff does? If so, this should be mentioned in the documentation.

~~ Brian
Johannes Schindelin· Mar 5, 2007, 23:14 UTC · re: Brian Gernhardt · lore

Re: [PATCH] Begin SubmittingPatches with a check list

Hi,
On Mon, 5 Mar 2007, Brian Gernhardt wrote:
Show 7 quoted lines
> On Mar 5, 2007, at 10:37 AM, Johannes Schindelin wrote:
> 
> > +	- use "git format-patch -M" to create the patch
> 
> The docco for git-format-patch doesn't list -M as one of it's options.  
> Is this one of the diff-options, and does it take all of the options 
> git-diff does?  If so, this should be mentioned in the documentation.

Actually, it is described briefly in the synopsis. But not in the options section. Care to provide a patch (see git-log.txt for an example how to include the diff options)?

Ciao, Dscho

← back to recent threads