Re: [PATCH] Use non-interactive function to byte-compile files

From: Karl Hasselström <kha@treskal.com>
Date: Mar 5, 2007, 09:51 UTC
Message-ID: <20070305095101.GA792@diana.vm.bytemark.co.uk>
In-Reply-To: <200703050823.l258NgT9008266@localhost.localdomain>

On 2007-03-05 09:23:42 +0100, Xavier Maillard wrote:

Show 16 quoted lines

> Hi,
>
> Ihope this one is more closed to what you expect to see in a
> commit log.
>
> * contrib/emacs/Makefile: add git-blame as a candidate to the
>    	    byte-compilation.  batch-byte-compile is the prefered way
>    	    to byte-compile files in batch mode. Use it instead of the
>    	    interactive function.
>
> Signed-off-by: Xavier Maillard <zedek@gnu.org>
> ---
>  contrib/emacs/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/emacs/Makefile b/contrib/emacs/Makefile

Unless you intended the "hi, I hope this is better" part to be part of the commit message, you should put it after the "---"; otherwise, Junio will have to fix it up by hand.

Yes, Documentation/SubmittingPatches is a loooong text ...

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle