{"thread":{"id":"7089","subject":"[PATCH] Use non-interactive function to byte-compile files","startedAt":"2007-03-05T08:23:42Z","lastAt":"2007-03-05T23:14:51Z","messageCount":8,"participants":["Xavier Maillard","Karl Hasselström","Johannes Schindelin","Alex Riesen","Brian Gernhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"36296","messageId":"200703050823.l258NgT9008266@localhost.localdomain","threadId":"7089","inReplyTo":null,"subject":"[PATCH] Use non-interactive function to byte-compile files","fromName":"Xavier Maillard","fromEmail":"zedek@gnu.org","sentAt":"2007-03-05T08:23:42Z","receivedAt":"2007-03-05T08:23:42Z","isPatch":true,"sender":{"key":"zedek@gnu.org","avatar":null},"body":"Hi,\n\nIhope this one is more closed to what you expect to see in a\ncommit log.\n\n* contrib/emacs/Makefile: add git-blame as a candidate to the\n \t byte-compilation. batch-byte-compile is the prefered way\n \t to byte-compile files in batch mode. Use it instead of the\n \t interactive function.\n\nSigned-off-by: Xavier Maillard \n---\n contrib/emacs/Makefile | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/emacs/Makefile b/contrib/emacs/Makefile\nindex 350846d..8554e39 100644\n--- a/contrib/emacs/Makefile\n+++ b/contrib/emacs/Makefile\n@@ -2,7 +2,7 @@\n \n EMACS = emacs\n \n-ELC = git.elc vc-git.elc\n+ELC = git.elc vc-git.elc git-blame.elc\n INSTALL ?= install\n INSTALL_ELC = $(INSTALL) -m 644\n prefix ?= $(HOME)\n@@ -15,6 +15,6 @@ install: all\n \t$(INSTALL_ELC) $(ELC) $(emacsdir)\n \n %.elc: %.el\n-\t$(EMACS) --batch --eval '(byte-compile-file \"$<\")'\n+\t$(EMACS) -batch -f batch-byte-compile $<\n \n clean:; rm -f $(ELC)\n-- \n1.5.0\n"},{"id":"36309","messageId":"20070305095101.GA792@diana.vm.bytemark.co.uk","threadId":"7089","inReplyTo":"200703050823.l258NgT9008266@localhost.localdomain","subject":"Re: [PATCH] Use non-interactive function to byte-compile files","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-03-05T09:51:01Z","receivedAt":"2007-03-05T09:51:01Z","isPatch":true,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2007-03-05 09:23:42 +0100, Xavier Maillard wrote:\n\n> Hi,\n>\n> Ihope this one is more closed to what you expect to see in a\n> commit log.\n>\n> * contrib/emacs/Makefile: add git-blame as a candidate to the\n> \t byte-compilation. batch-byte-compile is the prefered way\n> \t to byte-compile files in batch mode. Use it instead of the\n> \t interactive function.\n>\n> Signed-off-by: Xavier Maillard \n> ---\n> contrib/emacs/Makefile | 4 ++--\n> 1 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/contrib/emacs/Makefile b/contrib/emacs/Makefile\n\nUnless you intended the \"hi, I hope this is better\" part to be part of\nthe commit message, you should put it after the \"---\"; otherwise,\nJunio will have to fix it up by hand.\n\nYes, Documentation/SubmittingPatches is a loooong text ...\n\n-- \nKarl Hasselström, kha@treskal.com\n www.treskal.com/kalle\n"},{"id":"36326","messageId":"Pine.LNX.4.63.0703051554240.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7089","inReplyTo":"20070305095101.GA792@diana.vm.bytemark.co.uk","subject":"Re: [PATCH] Use non-interactive function to byte-compile files","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-03-05T14:54:46Z","receivedAt":"2007-03-05T14:54:46Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 5 Mar 2007, Karl Hasselström wrote:\n\n> Yes, Documentation/SubmittingPatches is a loooong text ...\n\nUnless you count all the MUA specific things, it is just 162 lines...\n\nCiao,\nDscho\n"},{"id":"36327","messageId":"20070305150418.GD3481@diana.vm.bytemark.co.uk","threadId":"7089","inReplyTo":"Pine.LNX.4.63.0703051554240.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Use non-interactive function to byte-compile files","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2007-03-05T15:04:18Z","receivedAt":"2007-03-05T15:04:18Z","isPatch":true,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2007-03-05 15:54:46 +0100, Johannes Schindelin wrote:\n\n> On Mon, 5 Mar 2007, Karl Hasselström wrote:\n>\n> > Yes, Documentation/SubmittingPatches is a loooong text ...\n>\n> Unless you count all the MUA specific things, it is just 162\n> lines...\n\nThere's still a lot of information in there. It's not hard to forget\none out of the ~28 paragraphs of non-MUA-specific info.\n\n-- \nKarl Hasselström, kha@treskal.com\n www.treskal.com/kalle\n"},{"id":"36331","messageId":"Pine.LNX.4.63.0703051631350.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7089","inReplyTo":"20070305150418.GD3481@diana.vm.bytemark.co.uk","subject":"[PATCH] Begin SubmittingPatches with a check list","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-03-05T15:37:54Z","receivedAt":"2007-03-05T15:37:54Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nIt seems that some people prefer a short list to a long text. But even for \nthe latter group, a quick reminder list is useful. So, add a check list to \nDocumentation/SubmittingPatches of what to do to get your patch accepted.\n\nSigned-off-by: Johannes Schindelin \n\n---\n\n\tOn Mon, 5 Mar 2007, Karl Hasselström wrote:\n\n\t> On 2007-03-05 15:54:46 +0100, Johannes Schindelin wrote:\n\t> \n\t> > On Mon, 5 Mar 2007, Karl Hasselström wrote:\n\t> >\n\t> > > Yes, Documentation/SubmittingPatches is a loooong text ...\n\t> >\n\t> > Unless you count all the MUA specific things, it is just 162\n\t> > lines...\n\t> \n\t> There's still a lot of information in there. It's not hard to \n\t> forget one out of the ~28 paragraphs of non-MUA-specific info.\n\n Documentation/SubmittingPatches | 25 +++++++++++++++++++++++++\n 1 files changed, 25 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 285781d..b6b3dd5 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -1,3 +1,28 @@\n+Short version for the impatient:\n+\n+\t- make commits of logical units\n+\t- check for unnecessary whitespace with \"git diff --check\"\n+\t before committing\n+\t- do not check in commented out code or unneeded files\n+\t- provide a meaningful commit message\n+\t- the first line of the commit message should be a short\n+\t description and should skip the full stop\n+\t- if you want your work included in git.git, add a\n+\t \"Signed-off-by: Your Name \" line to the\n+\t commit message (or just use the option \"-s\" when\n+\t committing) to confirm that you agree to the Developer's\n+\t Certificate of Origin\n+\t- do not PGP sign your patch\n+\t- use \"git format-patch -M\" to create the patch\n+\t- do not attach your patch, but paste it in the mail\n+\t mail body, unless you cannot teach your mailer to\n+\t leave the formatting of the patch alone\n+\t- provide additional information (which is unsuitable for\n+\t the commit message) between the \"---\" and the diffstat\n+\t- send the patch to the list _and_ the maintainer\n+\n+Long version:\n+\n I started reading over the SubmittingPatches document for Linux\n kernel, primarily because I wanted to have a document similar to\n it for the core GIT to make sure people understand what they are"},{"id":"36344","messageId":"81b0412b0703050928p441f8105m61b75f08958d9bb4@mail.gmail.com","threadId":"7089","inReplyTo":"Pine.LNX.4.63.0703051631350.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Begin SubmittingPatches with a check list","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-05T17:28:21Z","receivedAt":"2007-03-05T17:28:21Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 3/5/07, Johannes Schindelin wrote:\n> + - do not attach your patch, but paste it in the mail\n> + mail body, unless you cannot teach your mailer to\n> + leave the formatting of the patch alone\n\n\"mail\" twice in the first and seconf line\n"},{"id":"36364","messageId":"86B5B6C7-F53E-4272-95F8-90DEA33430BA@silverinsanity.com","threadId":"7089","inReplyTo":"Pine.LNX.4.63.0703051631350.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Begin SubmittingPatches with a check list","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-03-05T20:52:26Z","receivedAt":"2007-03-05T20:52:26Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Mar 5, 2007, at 10:37 AM, Johannes Schindelin wrote:\n\n> +\t- use \"git format-patch -M\" to create the patch\n\nThe docco for git-format-patch doesn't list -M as one of it's \noptions. Is this one of the diff-options, and does it take all of \nthe options git-diff does? If so, this should be mentioned in the \ndocumentation.\n\n~~ Brian\n"},{"id":"36380","messageId":"Pine.LNX.4.63.0703060013460.13683@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7089","inReplyTo":"86B5B6C7-F53E-4272-95F8-90DEA33430BA@silverinsanity.com","subject":"Re: [PATCH] Begin SubmittingPatches with a check list","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-03-05T23:14:51Z","receivedAt":"2007-03-05T23:14:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 5 Mar 2007, Brian Gernhardt wrote:\n\n> On Mar 5, 2007, at 10:37 AM, Johannes Schindelin wrote:\n> \n> > +\t- use \"git format-patch -M\" to create the patch\n> \n> The docco for git-format-patch doesn't list -M as one of it's options. \n> Is this one of the diff-options, and does it take all of the options \n> git-diff does? If so, this should be mentioned in the documentation.\n\nActually, it is described briefly in the synopsis. But not in the options \nsection. Care to provide a patch (see git-log.txt for an example how to \ninclude the diff options)?\n\nCiao,\nDscho\n"}]}