threads / patch / 6803

patchgit-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"

Subject: [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"

## tl;dr

2 messages between Feb 13, 2007 and Feb 13, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Andy Parkins· Feb 13, 2007, 15:26 UTC · lore
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
I think this would make git-gui get the wrong version number as the script
wouldn't complete successfully.
 git-gui/GIT-VERSION-GEN |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-gui/GIT-VERSION-GEN +1 −1
diff --git a/git-gui/GIT-VERSION-GEN b/git-gui/GIT-VERSION-GEN
index 8fac8cb..9966126 100755
--- a/git-gui/GIT-VERSION-GEN
+++ b/git-gui/GIT-VERSION-GEN
@@ -10,7 +10,7 @@ tree_search ()
 {
 	head=$1
 	tree=$2
-	for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
+	for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)
 	do
 		test $tree = $(git rev-parse $p^{tree} 2>/dev/null) &&
 		vn=$(git describe --abbrev=4 $p 2>/dev/null) &&
-- 
1.5.0.rc4.365.g5eff6
Shawn O. Pearce· Feb 13, 2007, 15:32 UTC · re: Andy Parkins · lore

Re: [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"

Andy Parkins <andyparkins@gmail.com> wrote:
> -	for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
> +	for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)
  [git (sp/gitgui)]$ ls /devnull
  /devnull
Gaaaaah.  Damn Mac.  Thanks for the patch, I'm applying it now.
-- 
Shawn.

← back to recent threads