# [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"

2 messages from 2007-02-13 to 2007-02-13. Participants: Andy Parkins, Shawn O. Pearce.
Thread: https://gitlist.dev/t/6803

## Andy Parkins, 2007-02-13 15:26

Subject: [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"
Message-ID: <200702131526.17153.andyparkins@gmail.com>
URL: https://gitlist.dev/e/200702131526.17153.andyparkins%40gmail.com

```
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
I think this would make git-gui get the wrong version number as the script
wouldn't complete successfully.

 git-gui/GIT-VERSION-GEN |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-gui/GIT-VERSION-GEN b/git-gui/GIT-VERSION-GEN
index 8fac8cb..9966126 100755
--- a/git-gui/GIT-VERSION-GEN
+++ b/git-gui/GIT-VERSION-GEN
@@ -10,7 +10,7 @@ tree_search ()
 {
 	head=$1
 	tree=$2
-	for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
+	for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)
 	do
 		test $tree = $(git rev-parse $p^{tree} 2>/dev/null) &&
 		vn=$(git describe --abbrev=4 $p 2>/dev/null) &&
-- 
1.5.0.rc4.365.g5eff6

```

## Shawn O. Pearce, 2007-02-13 15:32

Subject: Re: [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"
Message-ID: <20070213153211.GA28778@spearce.org>
URL: https://gitlist.dev/e/20070213153211.GA28778%40spearce.org
In-Reply-To: <200702131526.17153.andyparkins@gmail.com>

```
Andy Parkins <andyparkins@gmail.com> wrote:
> -	for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
> +	for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)

  [git (sp/gitgui)]$ ls /devnull
  /devnull

Gaaaaah.  Damn Mac.  Thanks for the patch, I'm applying it now.

-- 
Shawn.

```