{"thread":{"id":"6803","subject":"[PATCH] git-gui: fix typo in GIT-VERSION-GEN, \"/dev/null\" not \"/devnull\"","startedAt":"2007-02-13T15:26:16Z","lastAt":"2007-02-13T15:32:11Z","messageCount":2,"participants":["Andy Parkins","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"34414","messageId":"200702131526.17153.andyparkins@gmail.com","threadId":"6803","inReplyTo":null,"subject":"[PATCH] git-gui: fix typo in GIT-VERSION-GEN, \"/dev/null\" not \"/devnull\"","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-13T15:26:16Z","receivedAt":"2007-02-13T15:26:16Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"Signed-off-by: Andy Parkins <andyparkins@gmail.com>\n---\nI think this would make git-gui get the wrong version number as the script\nwouldn't complete successfully.\n\n git-gui/GIT-VERSION-GEN |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/GIT-VERSION-GEN b/git-gui/GIT-VERSION-GEN\nindex 8fac8cb..9966126 100755\n--- a/git-gui/GIT-VERSION-GEN\n+++ b/git-gui/GIT-VERSION-GEN\n@@ -10,7 +10,7 @@ tree_search ()\n {\n \thead=$1\n \ttree=$2\n-\tfor p in $(git rev-list --parents --max-count=1 $head 2>/devnull)\n+\tfor p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)\n \tdo\n \t\ttest $tree = $(git rev-parse $p^{tree} 2>/dev/null) &&\n \t\tvn=$(git describe --abbrev=4 $p 2>/dev/null) &&\n-- \n1.5.0.rc4.365.g5eff6\n"},{"id":"34415","messageId":"20070213153211.GA28778@spearce.org","threadId":"6803","inReplyTo":"200702131526.17153.andyparkins@gmail.com","subject":"Re: [PATCH] git-gui: fix typo in GIT-VERSION-GEN, \"/dev/null\" not \"/devnull\"","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-02-13T15:32:11Z","receivedAt":"2007-02-13T15:32:11Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Andy Parkins <andyparkins@gmail.com> wrote:\n> -\tfor p in $(git rev-list --parents --max-count=1 $head 2>/devnull)\n> +\tfor p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)\n\n  [git (sp/gitgui)]$ ls /devnull\n  /devnull\n\nGaaaaah.  Damn Mac.  Thanks for the patch, I'm applying it now.\n\n-- \nShawn.\n"}]}