{"thread":{"id":"66740","subject":"[PATCH] CodingGuidelines: update the required Perl version","startedAt":"2026-11-01T18:58:46Z","lastAt":"2026-11-05T18:45:08Z","messageCount":10,"participants":["Tuomas Ahola","Junio C Hamano","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"557088","messageId":"20261101185846.24208-1-taahol@utu.fi","threadId":"66740","inReplyTo":null,"subject":"[PATCH] CodingGuidelines: update the required Perl version","fromName":"Tuomas Ahola","fromEmail":"taahol@utu.fi","sentAt":"2026-11-01T18:58:46Z","receivedAt":"2026-11-01T18:58:46Z","isPatch":true,"sender":{"key":"taahol@utu.fi","avatar":"https://avatars.githubusercontent.com/u/114303477?v=4"},"body":"702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\nrequirement.  Update CodingGuidelines accordingly.\n\nSigned-off-by: Tuomas Ahola <taahol@utu.fi>\n---\n Documentation/CodingGuidelines | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\nindex c06f5d3071..9b17ab34db 100644\n--- a/Documentation/CodingGuidelines\n+++ b/Documentation/CodingGuidelines\n@@ -703,7 +703,7 @@ For Perl programs:\n \n  - Most of the C guidelines above apply.\n \n- - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n+ - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n \n  - use strict and use warnings are strongly preferred.\n \n\nbase-commit: a018953688f1b10bddf91bff8747068f5f4746a4\n-- \nta/coding-guidelines-perl-version\n\n\n"},{"id":"557113","messageId":"xmqqjymvooyn.fsf@gitster.g","threadId":"66740","inReplyTo":"20261101185846.24208-1-taahol@utu.fi","subject":"Re: [PATCH] CodingGuidelines: update the required Perl version","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-02T04:08:00Z","receivedAt":"2026-11-02T04:08:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tuomas Ahola <taahol@utu.fi> writes:\n\n> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\n> requirement.  Update CodingGuidelines accordingly.\n>\n> Signed-off-by: Tuomas Ahola <taahol@utu.fi>\n> ---\n>  Documentation/CodingGuidelines | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\n> index c06f5d3071..9b17ab34db 100644\n> --- a/Documentation/CodingGuidelines\n> +++ b/Documentation/CodingGuidelines\n> @@ -703,7 +703,7 @@ For Perl programs:\n>  \n>   - Most of the C guidelines above apply.\n>  \n> - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n> + - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n\nIs this in line with what 702d8c1f3b did?  Shouldn't we say\n\n> + - We try to support Perl 5.26.0 and later (\"require v5.26\").\n\n\"require v5.26\" instead?\n\ncommit 702d8c1f3b5377a64670b0f22add157b0bfc33dd\nAuthor: brian m. carlson <sandals@crustytoothpaste.net>\nDate:   Wed Oct 23 00:45:59 2024 +0000\n\n    Require Perl 5.26.0\n...    \n    This change was made with the following one-liner, which intentionally\n    excludes modifying the vendored modules we include to avoid conflicts:\n    \n        git grep -l 'use 5.008001' |\n\tgrep -v 'LoadCPAN/' |\n\txargs perl -pi -e 's/use 5.008001/require v5.26/'\n    \n    Use require instead of use to avoid changing the behavior as the latter\n    enables features and the former does not.\n    \n    Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>\n    Signed-off-by: Taylor Blau <me@ttaylorr.com>\n\ndiff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm\nindex 636add6968..3d061bc0b7 100644\n--- a/contrib/diff-highlight/DiffHighlight.pm\n+++ b/contrib/diff-highlight/DiffHighlight.pm\n@@ -1,6 +1,6 @@\n package DiffHighlight;\n \n-use 5.008001;\n+require v5.26;\n use warnings FATAL => 'all';\n use strict;\n\n"},{"id":"557117","messageId":"xmqq5wyfohv9.fsf@gitster.g","threadId":"66740","inReplyTo":"20261101185846.24208-1-taahol@utu.fi","subject":"Re: [PATCH] CodingGuidelines: update the required Perl version","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-02T06:41:14Z","receivedAt":"2026-11-02T06:41:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tuomas Ahola <taahol@utu.fi> writes:\n\n> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\n> requirement.  Update CodingGuidelines accordingly.\n>\n> Signed-off-by: Tuomas Ahola <taahol@utu.fi>\n> ---\n>  Documentation/CodingGuidelines | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nMakes sense.  Thanks.\n\n>\n> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\n> index c06f5d3071..9b17ab34db 100644\n> --- a/Documentation/CodingGuidelines\n> +++ b/Documentation/CodingGuidelines\n> @@ -703,7 +703,7 @@ For Perl programs:\n>  \n>   - Most of the C guidelines above apply.\n>  \n> - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n> + - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n>  \n>   - use strict and use warnings are strongly preferred.\n>  \n>\n> base-commit: a018953688f1b10bddf91bff8747068f5f4746a4\n\n"},{"id":"557490","messageId":"xmqqecd01kzs.fsf@gitster.g","threadId":"66740","inReplyTo":"xmqq5wyfohv9.fsf@gitster.g","subject":"Re: [PATCH] CodingGuidelines: update the required Perl version","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-04T18:59:03Z","receivedAt":"2026-11-04T18:59:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> Tuomas Ahola <taahol@utu.fi> writes:\n>\n>> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\n>> requirement.  Update CodingGuidelines accordingly.\n>>\n>> Signed-off-by: Tuomas Ahola <taahol@utu.fi>\n>> ---\n>>  Documentation/CodingGuidelines | 2 +-\n>>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> Makes sense.  Thanks.\n\nOh, no, not so fast.\n\nI'll mark the topic as \"Waiting for response\".\n\nhttps://lore.kernel.org/git/xmqqjymvooyn.fsf@gitster.g/\n\n\n"},{"id":"557493","messageId":"20261104193450.XvTBf%taahol@utu.fi","threadId":"66740","inReplyTo":"xmqqjymvooyn.fsf@gitster.g","subject":"Re: [PATCH] CodingGuidelines: update the required Perl version","fromName":"Tuomas Ahola","fromEmail":"taahol@utu.fi","sentAt":"2026-11-04T19:34:50Z","receivedAt":"2026-11-04T19:34:50Z","isPatch":true,"sender":{"key":"taahol@utu.fi","avatar":"https://avatars.githubusercontent.com/u/114303477?v=4"},"body":"Junio C Hamano <gitster@pobox.com> wrote:\n\n> Tuomas Ahola <taahol@utu.fi> writes:\n> \n> > 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\n> > requirement.  Update CodingGuidelines accordingly.\n> >\n> > Signed-off-by: Tuomas Ahola <taahol@utu.fi>\n> > ---\n> >  Documentation/CodingGuidelines | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\n> > index c06f5d3071..9b17ab34db 100644\n> > --- a/Documentation/CodingGuidelines\n> > +++ b/Documentation/CodingGuidelines\n> > @@ -703,7 +703,7 @@ For Perl programs:\n> >  \n> >   - Most of the C guidelines above apply.\n> >  \n> > - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n> > + - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n> \n> Is this in line with what 702d8c1f3b did?  Shouldn't we say\n> \n> > + - We try to support Perl 5.26.0 and later (\"require v5.26\").\n> \n> \"require v5.26\" instead?\n> \n\nFrankly, I don't make head nor tail of such Perl minutiae.  I would find that\nparenthetical much more useful if it told exactly when we are supposed to use\nsuch incantations.\n\nFor example:\n\n - All new code should carry the line \"require v5.26\".\n\nor\n\n - Please consider adding \"require v5.26\" whenever appropriate.\n\nI'm not really sure how to proceed with this.  One option is of course to adopt\nyour suggestion and call it a day.\n\n"},{"id":"557499","messageId":"xmqq5wyc1iba.fsf@gitster.g","threadId":"66740","inReplyTo":"20261104193450.XvTBf%taahol@utu.fi","subject":"Re: [PATCH] CodingGuidelines: update the required Perl version","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-04T19:56:57Z","receivedAt":"2026-11-04T19:56:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tuomas Ahola <taahol@utu.fi> writes:\n\n> Junio C Hamano <gitster@pobox.com> wrote:\n>\n>> Tuomas Ahola <taahol@utu.fi> writes:\n>> \n>> > 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\n>> > requirement.  Update CodingGuidelines accordingly.\n>> >\n>> > Signed-off-by: Tuomas Ahola <taahol@utu.fi>\n>> > ---\n>> >  Documentation/CodingGuidelines | 2 +-\n>> >  1 file changed, 1 insertion(+), 1 deletion(-)\n>> >\n>> > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\n>> > index c06f5d3071..9b17ab34db 100644\n>> > --- a/Documentation/CodingGuidelines\n>> > +++ b/Documentation/CodingGuidelines\n>> > @@ -703,7 +703,7 @@ For Perl programs:\n>> >  \n>> >   - Most of the C guidelines above apply.\n>> >  \n>> > - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n>> > + - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n>> \n>> Is this in line with what 702d8c1f3b did?  Shouldn't we say\n>> \n>> > + - We try to support Perl 5.26.0 and later (\"require v5.26\").\n>> \n>> \"require v5.26\" instead?\n>> \n>\n> Frankly, I don't make head nor tail of such Perl minutiae.  I would find that\n> parenthetical much more useful if it told exactly when we are supposed to use\n> such incantations.\n\nI do not claim to be intimately familiar, but you can consult the\ncommit you cited as the reason why you decided to make this update.\n\n    $ git show 702d8c1f3b\n    commit 702d8c1f3b5377a64670b0f22add157b0bfc33dd\n    Author: brian m. carlson <sandals@crustytoothpaste.net>\n    Date:   Wed Oct 23 00:45:59 2024 +0000\n\n        Require Perl 5.26.0\n\n        Our platform support policy states that we require \"versions of\n        ...\n        Use require instead of use to avoid changing the behavior as the latter\n        enables features and the former does not.\n\n        Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>\n        Signed-off-by: Taylor Blau <me@ttaylorr.com>\n\n    ...\n    diff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm\n    index 636add6968..3d061bc0b7 100644\n    --- a/contrib/diff-highlight/DiffHighlight.pm\n    +++ b/contrib/diff-highlight/DiffHighlight.pm\n    @@ -1,6 +1,6 @@\n     package DiffHighlight;\n\n    -use 5.008001;\n    +require v5.26;\n     use warnings FATAL => 'all';\n     use strict;\n\nIt looks to me that the \"parenthetical\" you called was designed to\nbe useful by telling you what to have near the top of your Perl\nsource files.  Replacing it with \"require v5.26\" is exactly in line\nwith that, I would think.\n\n"},{"id":"557507","messageId":"auuxjhaauAQ7Vtjs@fruit.crustytoothpaste.net","threadId":"66740","inReplyTo":"xmqq5wyc1iba.fsf@gitster.g","subject":"Re: [PATCH] CodingGuidelines: update the required Perl version","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2026-11-04T22:28:30Z","receivedAt":"2026-11-04T22:28:30Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2026-11-04 at 19:56:57, Junio C Hamano wrote:\n> Tuomas Ahola <taahol@utu.fi> writes:\n> \n> > Junio C Hamano <gitster@pobox.com> wrote:\n> >\n> >> Tuomas Ahola <taahol@utu.fi> writes:\n> >> \n> >> > - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n> >> > + - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n> >> \n> >> Is this in line with what 702d8c1f3b did?  Shouldn't we say\n> >> \n> >> > + - We try to support Perl 5.26.0 and later (\"require v5.26\").\n> >> \n> >> \"require v5.26\" instead?\n> >> \n> >\n> > Frankly, I don't make head nor tail of such Perl minutiae.  I would find that\n> > parenthetical much more useful if it told exactly when we are supposed to use\n> > such incantations.\n> \n> I do not claim to be intimately familiar, but you can consult the\n> commit you cited as the reason why you decided to make this update.\n> \n>     $ git show 702d8c1f3b\n>     commit 702d8c1f3b5377a64670b0f22add157b0bfc33dd\n>     Author: brian m. carlson <sandals@crustytoothpaste.net>\n>     Date:   Wed Oct 23 00:45:59 2024 +0000\n> \n>         Require Perl 5.26.0\n> \n>         Our platform support policy states that we require \"versions of\n>         ...\n>         Use require instead of use to avoid changing the behavior as the latter\n>         enables features and the former does not.\n> \n>         Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>\n>         Signed-off-by: Taylor Blau <me@ttaylorr.com>\n> \n>     ...\n>     diff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm\n>     index 636add6968..3d061bc0b7 100644\n>     --- a/contrib/diff-highlight/DiffHighlight.pm\n>     +++ b/contrib/diff-highlight/DiffHighlight.pm\n>     @@ -1,6 +1,6 @@\n>      package DiffHighlight;\n> \n>     -use 5.008001;\n>     +require v5.26;\n>      use warnings FATAL => 'all';\n>      use strict;\n> \n> It looks to me that the \"parenthetical\" you called was designed to\n> be useful by telling you what to have near the top of your Perl\n> source files.  Replacing it with \"require v5.26\" is exactly in line\n> with that, I would think.\n\nAs mentioned above, you want `require`, not `use`, with Perl versions.\nThe latter enables the relevant features, which include Unicode strings\nas of 5.12, and that will change the behaviour of our code in ways we're\nprobably not expecting.  That didn't happen in 5.8.1 because features\ndidn't exist, so the `use` for that version was okay.\n\nYou effectively always want `require v5.26` or something equivalent such\nas `require 5.026` in our codebase.  The former is nicer to read,\nthough.\n-- \nbrian m. carlson (they/them)\nToronto, Ontario, CA\nSpeaking for myself only\n"},{"id":"557585","messageId":"xmqqik2bw4y6.fsf@gitster.g","threadId":"66740","inReplyTo":"auuxjhaauAQ7Vtjs@fruit.crustytoothpaste.net","subject":"Re: [PATCH] CodingGuidelines: update the required Perl version","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-05T17:42:09Z","receivedAt":"2026-11-05T17:42:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" <sandals@crustytoothpaste.net> writes:\n\n> On 2026-11-04 at 19:56:57, Junio C Hamano wrote:\n>> Tuomas Ahola <taahol@utu.fi> writes:\n>> \n>> > Junio C Hamano <gitster@pobox.com> wrote:\n>> >\n>> >> Tuomas Ahola <taahol@utu.fi> writes:\n>> >> \n>> >> > - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n>> >> > + - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n>> >> \n>> >> Is this in line with what 702d8c1f3b did?  Shouldn't we say\n>> >> \n>> >> > + - We try to support Perl 5.26.0 and later (\"require v5.26\").\n>> >> \n>> >> \"require v5.26\" instead?\n>> ...\n>> It looks to me that the \"parenthetical\" you called was designed to\n>> be useful by telling you what to have near the top of your Perl\n>> source files.  Replacing it with \"require v5.26\" is exactly in line\n>> with that, I would think.\n>\n> As mentioned above, you want `require`, not `use`, with Perl versions.\n> The latter enables the relevant features, which include Unicode strings\n> as of 5.12, and that will change the behaviour of our code in ways we're\n> probably not expecting.  That didn't happen in 5.8.1 because features\n> didn't exist, so the `use` for that version was okay.\n>\n> You effectively always want `require v5.26` or something equivalent such\n> as `require 5.026` in our codebase.  The former is nicer to read,\n> though.\n\nThanks.  Let's see the final version that can immediately be marked\nas ready for 'next' then.\n\n\n"},{"id":"557597","messageId":"20261105183900.28597-1-taahol@utu.fi","threadId":"66740","inReplyTo":"20261101185846.24208-1-taahol@utu.fi","subject":"[PATCH v2] CodingGuidelines: update the required Perl version","fromName":"Tuomas Ahola","fromEmail":"taahol@utu.fi","sentAt":"2026-11-05T18:39:00Z","receivedAt":"2026-11-05T18:39:00Z","isPatch":true,"sender":{"key":"taahol@utu.fi","avatar":"https://avatars.githubusercontent.com/u/114303477?v=4"},"body":"702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\nrequirement and migrated the codebase to use \"require vx.y.z\" in lieu\nof \"use x.y_z\".  Update CodingGuidelines accordingly.\n\nHelped-by: brian m. carlson <sandals@crustytoothpaste.net>\nSigned-off-by: Tuomas Ahola <taahol@utu.fi>\n---\nIntervall-diff mot v1:\n1:  d18ca7697d ! 1:  70e2656643 CodingGuidelines: update the required Perl version\n    @@ Commit message\n         CodingGuidelines: update the required Perl version\n     \n         702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\n    -    requirement.  Update CodingGuidelines accordingly.\n    +    requirement and migrated the codebase to use \"require vx.y.z\" in lieu\n    +    of \"use x.y_z\".  Update CodingGuidelines accordingly.\n     \n    +    Helped-by: brian m. carlson <sandals@crustytoothpaste.net>\n         Signed-off-by: Tuomas Ahola <taahol@utu.fi>\n     \n      ## Documentation/CodingGuidelines ##\n    @@ Documentation/CodingGuidelines: For Perl programs:\n       - Most of the C guidelines above apply.\n      \n     - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n    -+ - We try to support Perl 5.26.0 and later (\"use Perl 5.026000\").\n    ++ - We try to support Perl 5.26.0 and later (\"require v5.26\").\n      \n       - use strict and use warnings are strongly preferred.\n      \n\n Documentation/CodingGuidelines | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\nindex c06f5d3071..bc0470c154 100644\n--- a/Documentation/CodingGuidelines\n+++ b/Documentation/CodingGuidelines\n@@ -703,7 +703,7 @@ For Perl programs:\n \n  - Most of the C guidelines above apply.\n \n- - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n+ - We try to support Perl 5.26.0 and later (\"require v5.26\").\n \n  - use strict and use warnings are strongly preferred.\n \n\nbase-commit: a018953688f1b10bddf91bff8747068f5f4746a4\n-- \nta/cg-require-perl-5.26.0\n\n\n"},{"id":"557598","messageId":"xmqqcxsjungr.fsf@gitster.g","threadId":"66740","inReplyTo":"20261105183900.28597-1-taahol@utu.fi","subject":"Re: [PATCH v2] CodingGuidelines: update the required Perl version","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-05T18:45:08Z","receivedAt":"2026-11-05T18:45:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tuomas Ahola <taahol@utu.fi> writes:\n\n> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version\n> requirement and migrated the codebase to use \"require vx.y.z\" in lieu\n> of \"use x.y_z\".  Update CodingGuidelines accordingly.\n>\n> Helped-by: brian m. carlson <sandals@crustytoothpaste.net>\n> Signed-off-by: Tuomas Ahola <taahol@utu.fi>\n> ---\n> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\n> index c06f5d3071..bc0470c154 100644\n> --- a/Documentation/CodingGuidelines\n> +++ b/Documentation/CodingGuidelines\n> @@ -703,7 +703,7 @@ For Perl programs:\n>  \n>   - Most of the C guidelines above apply.\n>  \n> - - We try to support Perl 5.8.1 and later (\"use Perl 5.008001\").\n> + - We try to support Perl 5.26.0 and later (\"require v5.26\").\n\nLooks good.  Will queue.\n\nThanks.\n\n\n"}]}