threads / patch / 66551

patcht2403: modernize test for directory existence

Subject: [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence

## tl;dr

3 messages between Oct 16, 2026 and Oct 23, 2026. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Shashank S via GitGitGadget· Oct 16, 2026, 04:31 UTC · lore
From: Shashank <shashu8660@gmail.com>

Replace the old-style shell `test -d` commands with Git's modern `test_path_is_dir` helper function.

This provides better debugging output if the tests were to fail, as the helper prints a clear error message rather than just failing silently like `test -d` does.

Signed-off-by: Shashank <shashu8660@gmail.com>
---
    [Outreachy PATCH] t2403: modernize test for directory existence
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2259%2Fshashu8660%2Foutreachy1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2259/shashu8660/outreachy1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2259
 t/t2403-worktree-move.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to t/t2403-worktree-move.sh +2 −2
diff --git a/t/t2403-worktree-move.sh b/t/t2403-worktree-move.sh
index 69768c1207..85793f9460 100755
--- a/t/t2403-worktree-move.sh
+++ b/t/t2403-worktree-move.sh
@@ -182,7 +182,7 @@ test_expect_success 'force remove worktree with untracked file' '
 
 test_expect_success 'remove missing worktree' '
 	git worktree add to-be-gone &&
-	test -d .git/worktrees/to-be-gone &&
+	test_path_is_dir .git/worktrees/to-be-gone &&
 	mv to-be-gone gone &&
 	git worktree remove to-be-gone &&
 	test_path_is_missing .git/worktrees/to-be-gone
@@ -191,7 +191,7 @@ test_expect_success 'remove missing worktree' '
 test_expect_success 'NOT remove missing-but-locked worktree' '
 	git worktree add gone-but-locked &&
 	git worktree lock gone-but-locked &&
-	test -d .git/worktrees/gone-but-locked &&
+	test_path_is_dir .git/worktrees/gone-but-locked &&
 	mv gone-but-locked really-gone-now &&
 	test_must_fail git worktree remove gone-but-locked &&
 	test_path_is_dir .git/worktrees/gone-but-locked

base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd

-- 
gitgitgadget
Junio C Hamano· Oct 23, 2026, 17:09 UTC · re: Usman Akinyemi · lore

Re: [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
Show 6 quoted lines
>> --
>> gitgitgadget
>
> Looks good to me.
>
> Thanks
Thanks, both.  Queued.

← back to recent threads