# [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence 3 messages from 2026-10-16 to 2026-10-23. Participants: Shashank S via GitGitGadget, Usman Akinyemi, Junio C Hamano. Thread: https://gitlist.dev/t/66551 ## Shashank S via GitGitGadget, 2026-10-16 04:31 Subject: [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence Message-ID: URL: https://gitlist.dev/e/pull.2259.git.1792125111461.gitgitgadget%40gmail.com ``` From: Shashank Replace the old-style shell `test -d` commands with Git's modern `test_path_is_dir` helper function. This provides better debugging output if the tests were to fail, as the helper prints a clear error message rather than just failing silently like `test -d` does. Signed-off-by: Shashank --- [Outreachy PATCH] t2403: modernize test for directory existence Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2259%2Fshashu8660%2Foutreachy1-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2259/shashu8660/outreachy1-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/2259 t/t2403-worktree-move.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t2403-worktree-move.sh b/t/t2403-worktree-move.sh index 69768c1207..85793f9460 100755 --- a/t/t2403-worktree-move.sh +++ b/t/t2403-worktree-move.sh @@ -182,7 +182,7 @@ test_expect_success 'force remove worktree with untracked file' ' test_expect_success 'remove missing worktree' ' git worktree add to-be-gone && - test -d .git/worktrees/to-be-gone && + test_path_is_dir .git/worktrees/to-be-gone && mv to-be-gone gone && git worktree remove to-be-gone && test_path_is_missing .git/worktrees/to-be-gone @@ -191,7 +191,7 @@ test_expect_success 'remove missing worktree' ' test_expect_success 'NOT remove missing-but-locked worktree' ' git worktree add gone-but-locked && git worktree lock gone-but-locked && - test -d .git/worktrees/gone-but-locked && + test_path_is_dir .git/worktrees/gone-but-locked && mv gone-but-locked really-gone-now && test_must_fail git worktree remove gone-but-locked && test_path_is_dir .git/worktrees/gone-but-locked base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd -- gitgitgadget ``` ## Usman Akinyemi, 2026-10-22 07:34 Subject: Re: [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence Message-ID: URL: https://gitlist.dev/e/CAPSxiM_gCkW3gvgF-ebK64bUS5za9CQgTFLAn-PnHS12o4afbA%40mail.gmail.com In-Reply-To: ``` > -- > gitgitgadget Looks good to me. Thanks ``` ## Junio C Hamano, 2026-10-23 17:09 Subject: Re: [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence Message-ID: URL: https://gitlist.dev/e/xmqqfqxw8ht0.fsf%40gitster.g In-Reply-To: ``` Usman Akinyemi writes: >> -- >> gitgitgadget > > Looks good to me. > > Thanks Thanks, both. Queued. ```