{"thread":{"id":"66551","subject":"[PATCH] [Outreachy PATCH] t2403: modernize test for directory existence","startedAt":"2026-10-16T04:31:51Z","lastAt":"2026-10-23T17:09:47Z","messageCount":3,"participants":["Shashank S via GitGitGadget","Usman Akinyemi","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"555207","messageId":"pull.2259.git.1792125111461.gitgitgadget@gmail.com","threadId":"66551","inReplyTo":null,"subject":"[PATCH] [Outreachy PATCH] t2403: modernize test for directory existence","fromName":"Shashank S via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-16T04:31:51Z","receivedAt":"2026-10-16T04:31:51Z","isPatch":true,"sender":{"key":"shashu8660@gmail.com","avatar":null},"body":"From: Shashank <shashu8660@gmail.com>\n\nReplace the old-style shell `test -d` commands with Git's modern\n`test_path_is_dir` helper function.\n\nThis provides better debugging output if the tests were to fail,\nas the helper prints a clear error message rather than just failing\nsilently like `test -d` does.\n\nSigned-off-by: Shashank <shashu8660@gmail.com>\n---\n    [Outreachy PATCH] t2403: modernize test for directory existence\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-2259%2Fshashu8660%2Foutreachy1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2259/shashu8660/outreachy1-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/2259\n\n t/t2403-worktree-move.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t2403-worktree-move.sh b/t/t2403-worktree-move.sh\nindex 69768c1207..85793f9460 100755\n--- a/t/t2403-worktree-move.sh\n+++ b/t/t2403-worktree-move.sh\n@@ -182,7 +182,7 @@ test_expect_success 'force remove worktree with untracked file' '\n \n test_expect_success 'remove missing worktree' '\n \tgit worktree add to-be-gone &&\n-\ttest -d .git/worktrees/to-be-gone &&\n+\ttest_path_is_dir .git/worktrees/to-be-gone &&\n \tmv to-be-gone gone &&\n \tgit worktree remove to-be-gone &&\n \ttest_path_is_missing .git/worktrees/to-be-gone\n@@ -191,7 +191,7 @@ test_expect_success 'remove missing worktree' '\n test_expect_success 'NOT remove missing-but-locked worktree' '\n \tgit worktree add gone-but-locked &&\n \tgit worktree lock gone-but-locked &&\n-\ttest -d .git/worktrees/gone-but-locked &&\n+\ttest_path_is_dir .git/worktrees/gone-but-locked &&\n \tmv gone-but-locked really-gone-now &&\n \ttest_must_fail git worktree remove gone-but-locked &&\n \ttest_path_is_dir .git/worktrees/gone-but-locked\n\nbase-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd\n-- \ngitgitgadget\n\n"},{"id":"555833","messageId":"CAPSxiM_gCkW3gvgF-ebK64bUS5za9CQgTFLAn-PnHS12o4afbA@mail.gmail.com","threadId":"66551","inReplyTo":"pull.2259.git.1792125111461.gitgitgadget@gmail.com","subject":"Re: [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2026-10-22T07:34:43Z","receivedAt":"2026-10-22T07:34:43Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"> --\n> gitgitgadget\n\nLooks good to me.\n\nThanks\n\n"},{"id":"556083","messageId":"xmqqfqxw8ht0.fsf@gitster.g","threadId":"66551","inReplyTo":"CAPSxiM_gCkW3gvgF-ebK64bUS5za9CQgTFLAn-PnHS12o4afbA@mail.gmail.com","subject":"Re: [PATCH] [Outreachy PATCH] t2403: modernize test for directory existence","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-23T17:09:47Z","receivedAt":"2026-10-23T17:09:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Usman Akinyemi <usmanakinyemi202@gmail.com> writes:\n\n>> --\n>> gitgitgadget\n>\n> Looks good to me.\n>\n> Thanks\n\nThanks, both.  Queued.\n\n"}]}