v3Re: [PATCH v3] SubmittingPatches: address design critiques
2 messages between Jun 19, 2026 and Jun 20, 2026, from Michael Montalbo, Junio C Hamano.
Plain Markdown or JSON for tools and agents. Diffs are folded; open one to read it.
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> +Be particularly mindful of critiques regarding the high-level design
> +or viability of your proposal (e.g., questioning if the feature is
> +worth implementing, or if the chosen approach is appropriate). Defend
> +your design decisions on the list first, work with reviewers and other
> +members to improve the design before revising the implementation, to
> +avoid wasting effort on an implementation before its design is solid.
Slight reflow suggestions:
Defend your design decisions on the list first; work with reviewers and
other members to improve the design before revising the implementation.
This will avoid wasting effort on an implementation before its design is
solid.
The rest looks good to me!
Michael Montalbo <mmontalbo@gmail.com> writes:
Show 6 quoted lines
> Slight reflow suggestions:
>
> Defend your design decisions on the list first; work with reviewers and
> other members to improve the design before revising the implementation.
> This will avoid wasting effort on an implementation before its design is
> solid.
Yeah, making the last part a separate sentence does make it much easier to follow. Will use.
Thanks.