Re: [PATCH v3] SubmittingPatches: address design critiques
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> +Be particularly mindful of critiques regarding the high-level design
> +or viability of your proposal (e.g., questioning if the feature is
> +worth implementing, or if the chosen approach is appropriate). Defend
> +your design decisions on the list first, work with reviewers and other
> +members to improve the design before revising the implementation, to
> +avoid wasting effort on an implementation before its design is solid.
Slight reflow suggestions:
Defend your design decisions on the list first; work with reviewers and
other members to improve the design before revising the implementation.
This will avoid wasting effort on an implementation before its design is
solid.
The rest looks good to me!