git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] SubmittingPatches: address design critiques

From
Michael Montalbo <mmontalbo@gmail.com>
Date
Jun 19, 2026, 22:40 UTC
Message-ID
<CAC2Qwm+WcGkd9pAV5=JL1hfCDRisGQRFmdfOsMTrMWyx7aa65A@mail.gmail.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> +Be particularly mindful of critiques regarding the high-level design
> +or viability of your proposal (e.g., questioning if the feature is
> +worth implementing, or if the chosen approach is appropriate).  Defend
> +your design decisions on the list first, work with reviewers and other
> +members to improve the design before revising the implementation, to
> +avoid wasting effort on an implementation before its design is solid.
Slight reflow suggestions:
  Defend your design decisions on the list first; work with reviewers and
  other members to improve the design before revising the implementation.
  This will avoid wasting effort on an implementation before its design is
  solid.
The rest looks good to me!
Next: Junio C Hamano
Message 1 of 2 in “Re: [PATCH v3] SubmittingPatches: address design critiques”
  1. Michael MontalboJun 19, 2026
  2. Junio C HamanoJun 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.