{"thread":{"id":"65844","subject":"Re: [PATCH v3] SubmittingPatches: address design critiques","startedAt":"2026-06-19T22:41:04Z","lastAt":"2026-06-20T14:09:19Z","messageCount":2,"participants":["Michael Montalbo","Junio C Hamano"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"546008","messageId":"CAC2Qwm+WcGkd9pAV5=JL1hfCDRisGQRFmdfOsMTrMWyx7aa65A@mail.gmail.com","threadId":"65844","inReplyTo":null,"subject":"Re: [PATCH v3] SubmittingPatches: address design critiques","fromName":"Michael Montalbo","fromEmail":"mmontalbo@gmail.com","sentAt":"2026-06-19T22:40:51Z","receivedAt":"2026-06-19T22:41:04Z","isPatch":true,"body":"Junio C Hamano <gitster@pobox.com> writes:\n> +Be particularly mindful of critiques regarding the high-level design\n> +or viability of your proposal (e.g., questioning if the feature is\n> +worth implementing, or if the chosen approach is appropriate).  Defend\n> +your design decisions on the list first, work with reviewers and other\n> +members to improve the design before revising the implementation, to\n> +avoid wasting effort on an implementation before its design is solid.\n\nSlight reflow suggestions:\n\n  Defend your design decisions on the list first; work with reviewers and\n  other members to improve the design before revising the implementation.\n  This will avoid wasting effort on an implementation before its design is\n  solid.\n\nThe rest looks good to me!\n"},{"id":"546029","messageId":"xmqqqzm1gv76.fsf@gitster.g","threadId":"65844","inReplyTo":"CAC2Qwm+WcGkd9pAV5=JL1hfCDRisGQRFmdfOsMTrMWyx7aa65A@mail.gmail.com","subject":"Re: [PATCH v3] SubmittingPatches: address design critiques","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-06-20T14:09:17Z","receivedAt":"2026-06-20T14:09:19Z","isPatch":true,"body":"Michael Montalbo <mmontalbo@gmail.com> writes:\n\n> Slight reflow suggestions:\n>\n>   Defend your design decisions on the list first; work with reviewers and\n>   other members to improve the design before revising the implementation.\n>   This will avoid wasting effort on an implementation before its design is\n>   solid.\n\nYeah, making the last part a separate sentence does make it much\neasier to follow.  Will use.\n\nThanks.\n"}]}