Volume XXII, number 280Wednesday, October 7, 2026Latest message 2 hours ago

The Git List

News and archive of git@vger.kernel.org, since April 2005

v2Re: [PATCH v2] SubmittingPatches: address design critiques

1 messages between Jun 18, 2026 and Jun 18, 2026, from Michael Montalbo.

Plain Markdown or JSON for tools and agents. Diffs are folded; open one to read it.

Michael MontalboJun 18, 2026, 15:36 UTC on lore
Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> +You should be particularly mindful of critiques regarding the
> +high-level design or viability of your proposal (e.g., questioning
> +whether the feature is worth implementing, or if the chosen approach
> +is appropriate).  Defend your design decisions on the list first, to
> +avoid wasting effort on an implementation whose design is not yet
> +solid.
> ++
> +Make sure that any new version is accompanied by a much clearer
> +explanation and justification (in the cover letter, your responses,
> +and in the revised commit messages).  Aim to make the reviewers say
> +"it is now clear why we may want to do this with the updated version".
> ++
> +Topics that fail to address fundamental design critiques without
> +resolution will not be considered ready for merging.
This wording looks good to me.

Back to recent threads

Re: [PATCH v2] SubmittingPatches: address design critiques | The Git List