{"thread":{"id":"65835","subject":"Re: [PATCH v2] SubmittingPatches: address design critiques","startedAt":"2026-06-18T15:36:17Z","lastAt":"2026-06-18T15:36:17Z","messageCount":1,"participants":["Michael Montalbo"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"545859","messageId":"CAC2QwmLy3WZbGYC14kYuC-BmLGFi6ztTEoqZdo+hVTQt+6=y=A@mail.gmail.com","threadId":"65835","inReplyTo":null,"subject":"Re: [PATCH v2] SubmittingPatches: address design critiques","fromName":"Michael Montalbo","fromEmail":"mmontalbo@gmail.com","sentAt":"2026-06-18T15:36:03Z","receivedAt":"2026-06-18T15:36:17Z","isPatch":true,"body":"Junio C Hamano <gitster@pobox.com> wrote:\n> +You should be particularly mindful of critiques regarding the\n> +high-level design or viability of your proposal (e.g., questioning\n> +whether the feature is worth implementing, or if the chosen approach\n> +is appropriate).  Defend your design decisions on the list first, to\n> +avoid wasting effort on an implementation whose design is not yet\n> +solid.\n> ++\n> +Make sure that any new version is accompanied by a much clearer\n> +explanation and justification (in the cover letter, your responses,\n> +and in the revised commit messages).  Aim to make the reviewers say\n> +\"it is now clear why we may want to do this with the updated version\".\n> ++\n> +Topics that fail to address fundamental design critiques without\n> +resolution will not be considered ready for merging.\n\nThis wording looks good to me.\n"}]}