git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] SubmittingPatches: address design critiques

From
Michael Montalbo <mmontalbo@gmail.com>
Date
Jun 18, 2026, 15:36 UTC
Message-ID
<CAC2QwmLy3WZbGYC14kYuC-BmLGFi6ztTEoqZdo+hVTQt+6=y=A@mail.gmail.com>
Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> +You should be particularly mindful of critiques regarding the
> +high-level design or viability of your proposal (e.g., questioning
> +whether the feature is worth implementing, or if the chosen approach
> +is appropriate).  Defend your design decisions on the list first, to
> +avoid wasting effort on an implementation whose design is not yet
> +solid.
> ++
> +Make sure that any new version is accompanied by a much clearer
> +explanation and justification (in the cover letter, your responses,
> +and in the revised commit messages).  Aim to make the reviewers say
> +"it is now clear why we may want to do this with the updated version".
> ++
> +Topics that fail to address fundamental design critiques without
> +resolution will not be considered ready for merging.
This wording looks good to me.
Message 1 of 1 in “Re: [PATCH v2] SubmittingPatches: address design critiques”
  1. Michael MontalboJun 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.