Volume XXII, number 280Wednesday, October 7, 2026Latest message 2 hours ago

The Git List

News and archive of git@vger.kernel.org, since April 2005

patchRe: [PATCH] SubmittingPatches: address design critiques

1 messages between Jun 18, 2026 and Jun 18, 2026, from Michael Montalbo.

Plain Markdown or JSON for tools and agents. Diffs are folded; open one to read it.

Michael MontalboJun 18, 2026, 15:17 UTC on lore
On Wed, Jun 17, 2026 at 8:53 PM Michael Montalbo <mmontalbo@gmail.com> wrote:
Show 14 quoted lines
>
> Junio C Hamano wrote:
> > +You would want to be particularly mindful of critiques regarding the
> > +high-level design or viability of your proposal (e.g., questioning
> > +whether the feature is worth implementing, or if the chosen approach
> > +is appropriate).  You want to defend your design decisions on the list
> > +first, because you do not want to spend too much effort in the
> > +implementation if the design is not yet solid.
>
> Two small suggestions: open with a direct imperative and replace
> "effort in the implementation" with "effort on the implementation".
>
>     [B]e particularly mindful of...
>     ... too much effort [on] the implementation...
(resending to fix threading)
Maybe we can even more directly say:

Do not spend too much effort on the implementation if the design is not yet solid. Be able to defend your design decisions on the list first.

Back to recent threads