git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] SubmittingPatches: address design critiques

From
Michael Montalbo <mmontalbo@gmail.com>
Date
Jun 18, 2026, 15:17 UTC
Message-ID
<CAC2Qwm+DLtWB_2ZpvLmF0AjACVQVeRW1VVPjXXiFcSSMMn4SjA@mail.gmail.com>
On Wed, Jun 17, 2026 at 8:53 PM Michael Montalbo <mmontalbo@gmail.com> wrote:
Show 14 quoted lines
>
> Junio C Hamano wrote:
> > +You would want to be particularly mindful of critiques regarding the
> > +high-level design or viability of your proposal (e.g., questioning
> > +whether the feature is worth implementing, or if the chosen approach
> > +is appropriate).  You want to defend your design decisions on the list
> > +first, because you do not want to spend too much effort in the
> > +implementation if the design is not yet solid.
>
> Two small suggestions: open with a direct imperative and replace
> "effort in the implementation" with "effort on the implementation".
>
>     [B]e particularly mindful of...
>     ... too much effort [on] the implementation...
(resending to fix threading)
Maybe we can even more directly say:

Do not spend too much effort on the implementation if the design is not yet solid. Be able to defend your design decisions on the list first.

Message 1 of 1 in “Re: [PATCH] SubmittingPatches: address design critiques”
  1. Michael MontalboJun 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.