{"thread":{"id":"65834","subject":"Re: [PATCH] SubmittingPatches: address design critiques","startedAt":"2026-06-18T15:17:15Z","lastAt":"2026-06-18T15:17:15Z","messageCount":1,"participants":["Michael Montalbo"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"545858","messageId":"CAC2Qwm+DLtWB_2ZpvLmF0AjACVQVeRW1VVPjXXiFcSSMMn4SjA@mail.gmail.com","threadId":"65834","inReplyTo":null,"subject":"Re: [PATCH] SubmittingPatches: address design critiques","fromName":"Michael Montalbo","fromEmail":"mmontalbo@gmail.com","sentAt":"2026-06-18T15:17:02Z","receivedAt":"2026-06-18T15:17:15Z","isPatch":true,"body":"On Wed, Jun 17, 2026 at 8:53 PM Michael Montalbo <mmontalbo@gmail.com> wrote:\n>\n> Junio C Hamano wrote:\n> > +You would want to be particularly mindful of critiques regarding the\n> > +high-level design or viability of your proposal (e.g., questioning\n> > +whether the feature is worth implementing, or if the chosen approach\n> > +is appropriate).  You want to defend your design decisions on the list\n> > +first, because you do not want to spend too much effort in the\n> > +implementation if the design is not yet solid.\n>\n> Two small suggestions: open with a direct imperative and replace\n> \"effort in the implementation\" with \"effort on the implementation\".\n>\n>     [B]e particularly mindful of...\n>     ... too much effort [on] the implementation...\n\n(resending to fix threading)\n\nMaybe we can even more directly say:\n\nDo not spend too much effort on the implementation if the design is not\nyet solid. Be able to defend your design decisions on the list first.\n"}]}