Volume XXII, number 280Wednesday, October 7, 2026Latest message 1 hour ago

The Git List

News and archive of git@vger.kernel.org, since April 2005

patchdoc: fix git grep args order in Quick Reference

2 messages between Mar 16, 2026 and Mar 16, 2026, from Guillaume Jacob via GitGitGadget, Junio C Hamano.

Plain Markdown or JSON for tools and agents. Diffs are folded; open one to read it.

Guillaume Jacob via GitGitGadgetMar 16, 2026, 14:15 UTC on lore
From: Guillaume Jacob <guillaume@absolut-sensing.com>

The example provided has its arguments in the wrong order. The revision should follow the pattern, and not the other way around.

Signed-off-by: Guillaume Jacob <guillaume@absolut-sensing.com>
---
    doc: fix git grep args order in Quick Reference
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2069
 Documentation/user-manual.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/user-manual.adoc +1 −1
diff --git a/Documentation/user-manual.adoc b/Documentation/user-manual.adoc
index 7696987117..64009baf37 100644
--- a/Documentation/user-manual.adoc
+++ b/Documentation/user-manual.adoc
@@ -4466,7 +4466,7 @@ $ git show		    # most recent commit
 $ git diff v2.6.15..v2.6.16 # diff between two tagged versions
 $ git diff v2.6.15..HEAD    # diff with current head
 $ git grep "foo()"	    # search working directory for "foo()"
-$ git grep v2.6.15 "foo()"  # search old tree for "foo()"
+$ git grep "foo()" v2.6.15  # search old tree for "foo()"
 $ git show v2.6.15:a.txt    # look at old version of a.txt
 -----------------------------------------------
 

base-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1
-- 
gitgitgadget
Junio C HamanoMar 16, 2026, 17:16 UTC in reply to Guillaume Jacob via GitGitGadget on lore

Re: [PATCH] doc: fix git grep args order in Quick Reference

"Guillaume Jacob via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Guillaume Jacob <guillaume@absolut-sensing.com>
>
> The example provided has its arguments in the wrong order. The revision
> should follow the pattern, and not the other way around.
Well written.  The patch title also comforms our convention.
>
> Signed-off-by: Guillaume Jacob <guillaume@absolut-sensing.com>
> ---

Signed off correctly with the same identity as in-body From: line. The patch contents also is reasonable.

Will queue.  Thanks.
Show 24 quoted lines
>     doc: fix git grep args order in Quick Reference
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2069
>
>  Documentation/user-manual.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/user-manual.adoc b/Documentation/user-manual.adoc
> index 7696987117..64009baf37 100644
> --- a/Documentation/user-manual.adoc
> +++ b/Documentation/user-manual.adoc
> @@ -4466,7 +4466,7 @@ $ git show		    # most recent commit
>  $ git diff v2.6.15..v2.6.16 # diff between two tagged versions
>  $ git diff v2.6.15..HEAD    # diff with current head
>  $ git grep "foo()"	    # search working directory for "foo()"
> -$ git grep v2.6.15 "foo()"  # search old tree for "foo()"
> +$ git grep "foo()" v2.6.15  # search old tree for "foo()"
>  $ git show v2.6.15:a.txt    # look at old version of a.txt
>  -----------------------------------------------
>  
>
> base-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1

Back to recent threads

[PATCH] doc: fix git grep args order in Quick Reference | The Git List