{"thread":{"id":"65268","subject":"[PATCH] doc: fix git grep args order in Quick Reference","startedAt":"2026-03-16T14:15:41Z","lastAt":"2026-03-16T17:16:55Z","messageCount":2,"participants":["Guillaume Jacob via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"539108","messageId":"pull.2069.git.1773670536808.gitgitgadget@gmail.com","threadId":"65268","inReplyTo":null,"subject":"[PATCH] doc: fix git grep args order in Quick Reference","fromName":"Guillaume Jacob via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-03-16T14:15:36Z","receivedAt":"2026-03-16T14:15:41Z","isPatch":true,"sender":{"key":"name:Guillaume Jacob","avatar":null},"body":"From: Guillaume Jacob <guillaume@absolut-sensing.com>\n\nThe example provided has its arguments in the wrong order. The revision\nshould follow the pattern, and not the other way around.\n\nSigned-off-by: Guillaume Jacob <guillaume@absolut-sensing.com>\n---\n    doc: fix git grep args order in Quick Reference\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/2069\n\n Documentation/user-manual.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/user-manual.adoc b/Documentation/user-manual.adoc\nindex 7696987117..64009baf37 100644\n--- a/Documentation/user-manual.adoc\n+++ b/Documentation/user-manual.adoc\n@@ -4466,7 +4466,7 @@ $ git show\t\t    # most recent commit\n $ git diff v2.6.15..v2.6.16 # diff between two tagged versions\n $ git diff v2.6.15..HEAD    # diff with current head\n $ git grep \"foo()\"\t    # search working directory for \"foo()\"\n-$ git grep v2.6.15 \"foo()\"  # search old tree for \"foo()\"\n+$ git grep \"foo()\" v2.6.15  # search old tree for \"foo()\"\n $ git show v2.6.15:a.txt    # look at old version of a.txt\n -----------------------------------------------\n \n\nbase-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1\n-- \ngitgitgadget\n"},{"id":"539139","messageId":"xmqqikavpud7.fsf@gitster.g","threadId":"65268","inReplyTo":"pull.2069.git.1773670536808.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: fix git grep args order in Quick Reference","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-03-16T17:16:52Z","receivedAt":"2026-03-16T17:16:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Guillaume Jacob via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Guillaume Jacob <guillaume@absolut-sensing.com>\n>\n> The example provided has its arguments in the wrong order. The revision\n> should follow the pattern, and not the other way around.\n\nWell written.  The patch title also comforms our convention.\n\n>\n> Signed-off-by: Guillaume Jacob <guillaume@absolut-sensing.com>\n> ---\n\nSigned off correctly with the same identity as in-body From: line.\nThe patch contents also is reasonable.\n\nWill queue.  Thanks.\n\n\n>     doc: fix git grep args order in Quick Reference\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/2069\n>\n>  Documentation/user-manual.adoc | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/user-manual.adoc b/Documentation/user-manual.adoc\n> index 7696987117..64009baf37 100644\n> --- a/Documentation/user-manual.adoc\n> +++ b/Documentation/user-manual.adoc\n> @@ -4466,7 +4466,7 @@ $ git show\t\t    # most recent commit\n>  $ git diff v2.6.15..v2.6.16 # diff between two tagged versions\n>  $ git diff v2.6.15..HEAD    # diff with current head\n>  $ git grep \"foo()\"\t    # search working directory for \"foo()\"\n> -$ git grep v2.6.15 \"foo()\"  # search old tree for \"foo()\"\n> +$ git grep \"foo()\" v2.6.15  # search old tree for \"foo()\"\n>  $ git show v2.6.15:a.txt    # look at old version of a.txt\n>  -----------------------------------------------\n>  \n>\n> base-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1\n"}]}