Re: [PATCH] doc: fix git grep args order in Quick Reference

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2026, 17:16 UTC
Message-ID: <xmqqikavpud7.fsf@gitster.g>
In-Reply-To: <pull.2069.git.1773670536808.gitgitgadget@gmail.com>

"Guillaume Jacob via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Guillaume Jacob <guillaume@absolut-sensing.com>
>
> The example provided has its arguments in the wrong order. The revision
> should follow the pattern, and not the other way around.

Well written.  The patch title also comforms our convention.

>
> Signed-off-by: Guillaume Jacob <guillaume@absolut-sensing.com>
> ---

Signed off correctly with the same identity as in-body From: line. The patch contents also is reasonable.

Will queue.  Thanks.

Show 24 quoted lines

>     doc: fix git grep args order in Quick Reference
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2069
>
>  Documentation/user-manual.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/user-manual.adoc b/Documentation/user-manual.adoc
> index 7696987117..64009baf37 100644
> --- a/Documentation/user-manual.adoc
> +++ b/Documentation/user-manual.adoc
> @@ -4466,7 +4466,7 @@ $ git show		    # most recent commit
>  $ git diff v2.6.15..v2.6.16 # diff between two tagged versions
>  $ git diff v2.6.15..HEAD    # diff with current head
>  $ git grep "foo()"	    # search working directory for "foo()"
> -$ git grep v2.6.15 "foo()"  # search old tree for "foo()"
> +$ git grep "foo()" v2.6.15  # search old tree for "foo()"
>  $ git show v2.6.15:a.txt    # look at old version of a.txt
>  -----------------------------------------------
>  
>
> base-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1