threads / patch / 6307

patchgitk errors out if launched in a subdirectory

Subject: [PATCH] gitk errors out if launched in a subdirectory

## tl;dr

5 messages between Jan 9, 2007 and Jan 13, 2007. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Peter Baumann· Jan 9, 2007, 14:30 UTC · lore

Make gitk use git-rev-parse --git-dir to find the repository.

Signed-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
---
 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to gitk +1 −1

diff --git a/gitk b/gitk
index 3dabc69..ec4f1bd 100755
--- a/gitk
+++ b/gitk
@@ -12,7 +12,7 @@ proc gitdir {} {
     if {[info exists env(GIT_DIR)]} {
 	return $env(GIT_DIR)
     } else {
-	return ".git"
+	return [exec git rev-parse --git-dir]
     }
 }

-- 
1.4.4.2

Peter Baumann· Jan 12, 2007, 17:43 UTC · re: Peter Baumann · lore

Re: [PATCH] gitk errors out if launched in a subdirectory

Is there something obviously wrong with this patch? It is the second time I send this (or a slight variant; last time I even removed the enviroment checking) and nobody answered.

Please say so if it is NAKed.

-Peter

On Tue, Jan 09, 2007 at 03:30:19PM +0100, Peter Baumann wrote:

Show 23 quoted lines

> Make gitk use git-rev-parse --git-dir to find the repository.
> 
> Signed-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
> ---
>  gitk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gitk b/gitk
> index 3dabc69..ec4f1bd 100755
> --- a/gitk
> +++ b/gitk
> @@ -12,7 +12,7 @@ proc gitdir {} {
>      if {[info exists env(GIT_DIR)]} {
>  	return $env(GIT_DIR)
>      } else {
> -	return ".git"
> +	return [exec git rev-parse --git-dir]
>      }
>  }
>  
> -- 
> 1.4.4.2
>

Junio C Hamano· Jan 12, 2007, 17:59 UTC · re: Peter Baumann · lore

Re: [PATCH] gitk errors out if launched in a subdirectory

Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de> writes:

Show 5 quoted lines

> Is there something obviously wrong with this patch? It is the second
> time I send this (or a slight variant; last time I even removed the
> enviroment checking) and nobody answered.
>
> Please say so if it is NAKed.

I am Ok with it if Paul is.  I think it makes sense.

Paul Mackerras· Jan 13, 2007, 03:13 UTC · re: Peter Baumann · lore

Re: [PATCH] gitk errors out if launched in a subdirectory

Peter Baumann writes:

Show 5 quoted lines

> Is there something obviously wrong with this patch? It is the second
> time I send this (or a slight variant; last time I even removed the
> enviroment checking) and nobody answered.
> 
> Please say so if it is NAKed.

No, it looks fine. It's just that gitk takes a lower priority than some other things in my life.

Paul.

Peter Baumann· Jan 13, 2007, 16:10 UTC · re: Paul Mackerras · lore

Re: [PATCH] gitk errors out if launched in a subdirectory

On Sat, Jan 13, 2007 at 02:13:58PM +1100, Paul Mackerras wrote:

Show 13 quoted lines

> Peter Baumann writes:
> 
> > Is there something obviously wrong with this patch? It is the second
> > time I send this (or a slight variant; last time I even removed the
> > enviroment checking) and nobody answered.
> > 
> > Please say so if it is NAKed.
> 
> No, it looks fine.  It's just that gitk takes a lower priority than
> some other things in my life.
> 
> Paul.
>

Ok. No problem then. I just felt a little bit stupid after posting the this simple fix the second time and nobody carred.

-Peter