Re: [PATCH] gitk errors out if launched in a subdirectory

From: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
Date: Jan 12, 2007, 17:43 UTC
Message-ID: <20070112174340.GA6262@xp.machine.xx>
In-Reply-To: <20070109143019.GA24688@xp.machine.xx>

Is there something obviously wrong with this patch? It is the second time I send this (or a slight variant; last time I even removed the enviroment checking) and nobody answered.

Please say so if it is NAKed.

-Peter

On Tue, Jan 09, 2007 at 03:30:19PM +0100, Peter Baumann wrote:

Show 23 quoted lines

> Make gitk use git-rev-parse --git-dir to find the repository.
> 
> Signed-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
> ---
>  gitk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gitk b/gitk
> index 3dabc69..ec4f1bd 100755
> --- a/gitk
> +++ b/gitk
> @@ -12,7 +12,7 @@ proc gitdir {} {
>      if {[info exists env(GIT_DIR)]} {
>  	return $env(GIT_DIR)
>      } else {
> -	return ".git"
> +	return [exec git rev-parse --git-dir]
>      }
>  }
>  
> -- 
> 1.4.4.2
>