{"thread":{"id":"6307","subject":"[PATCH] gitk errors out if launched in a subdirectory","startedAt":"2007-01-09T14:30:19Z","lastAt":"2007-01-13T16:10:57Z","messageCount":5,"participants":["Peter Baumann","Junio C Hamano","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"31246","messageId":"20070109143019.GA24688@xp.machine.xx","threadId":"6307","inReplyTo":null,"subject":"[PATCH] gitk errors out if launched in a subdirectory","fromName":"Peter Baumann","fromEmail":"siprbaum@stud.informatik.uni-erlangen.de","sentAt":"2007-01-09T14:30:19Z","receivedAt":"2007-01-09T14:30:19Z","isPatch":true,"sender":{"key":"waste.manager@gmx.de","avatar":null},"body":"Make gitk use git-rev-parse --git-dir to find the repository.\n\nSigned-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>\n---\n gitk |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 3dabc69..ec4f1bd 100755\n--- a/gitk\n+++ b/gitk\n@@ -12,7 +12,7 @@ proc gitdir {} {\n     if {[info exists env(GIT_DIR)]} {\n \treturn $env(GIT_DIR)\n     } else {\n-\treturn \".git\"\n+\treturn [exec git rev-parse --git-dir]\n     }\n }\n \n-- \n1.4.4.2\n"},{"id":"31566","messageId":"20070112174340.GA6262@xp.machine.xx","threadId":"6307","inReplyTo":"20070109143019.GA24688@xp.machine.xx","subject":"Re: [PATCH] gitk errors out if launched in a subdirectory","fromName":"Peter Baumann","fromEmail":"siprbaum@stud.informatik.uni-erlangen.de","sentAt":"2007-01-12T17:43:40Z","receivedAt":"2007-01-12T17:43:40Z","isPatch":true,"sender":{"key":"waste.manager@gmx.de","avatar":null},"body":"Is there something obviously wrong with this patch? It is the second\ntime I send this (or a slight variant; last time I even removed the\nenviroment checking) and nobody answered.\n\nPlease say so if it is NAKed.\n\n-Peter\n\n\nOn Tue, Jan 09, 2007 at 03:30:19PM +0100, Peter Baumann wrote:\n> Make gitk use git-rev-parse --git-dir to find the repository.\n> \n> Signed-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>\n> ---\n>  gitk |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/gitk b/gitk\n> index 3dabc69..ec4f1bd 100755\n> --- a/gitk\n> +++ b/gitk\n> @@ -12,7 +12,7 @@ proc gitdir {} {\n>      if {[info exists env(GIT_DIR)]} {\n>  \treturn $env(GIT_DIR)\n>      } else {\n> -\treturn \".git\"\n> +\treturn [exec git rev-parse --git-dir]\n>      }\n>  }\n>  \n> -- \n> 1.4.4.2\n> \n"},{"id":"31568","messageId":"7vvejct9bo.fsf@assigned-by-dhcp.cox.net","threadId":"6307","inReplyTo":"20070112174340.GA6262@xp.machine.xx","subject":"Re: [PATCH] gitk errors out if launched in a subdirectory","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-12T17:59:39Z","receivedAt":"2007-01-12T17:59:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de> writes:\n\n> Is there something obviously wrong with this patch? It is the second\n> time I send this (or a slight variant; last time I even removed the\n> enviroment checking) and nobody answered.\n>\n> Please say so if it is NAKed.\n\nI am Ok with it if Paul is.  I think it makes sense.\n"},{"id":"31620","messageId":"17832.20086.20532.159295@cargo.ozlabs.ibm.com","threadId":"6307","inReplyTo":"20070112174340.GA6262@xp.machine.xx","subject":"Re: [PATCH] gitk errors out if launched in a subdirectory","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2007-01-13T03:13:58Z","receivedAt":"2007-01-13T03:13:58Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Peter Baumann writes:\n\n> Is there something obviously wrong with this patch? It is the second\n> time I send this (or a slight variant; last time I even removed the\n> enviroment checking) and nobody answered.\n> \n> Please say so if it is NAKed.\n\nNo, it looks fine.  It's just that gitk takes a lower priority than\nsome other things in my life.\n\nPaul.\n"},{"id":"31635","messageId":"20070113161057.GA28354@xp.machine.xx","threadId":"6307","inReplyTo":"17832.20086.20532.159295@cargo.ozlabs.ibm.com","subject":"Re: [PATCH] gitk errors out if launched in a subdirectory","fromName":"Peter Baumann","fromEmail":"siprbaum@stud.informatik.uni-erlangen.de","sentAt":"2007-01-13T16:10:57Z","receivedAt":"2007-01-13T16:10:57Z","isPatch":true,"sender":{"key":"waste.manager@gmx.de","avatar":null},"body":"On Sat, Jan 13, 2007 at 02:13:58PM +1100, Paul Mackerras wrote:\n> Peter Baumann writes:\n> \n> > Is there something obviously wrong with this patch? It is the second\n> > time I send this (or a slight variant; last time I even removed the\n> > enviroment checking) and nobody answered.\n> > \n> > Please say so if it is NAKed.\n> \n> No, it looks fine.  It's just that gitk takes a lower priority than\n> some other things in my life.\n> \n> Paul.\n> \n\nOk. No problem then. I just felt a little bit stupid after posting the\nthis simple fix the second time and nobody carred.\n\n-Peter\n"}]}