threads / patch / 62899

patchcontrib/vscode: respect configurable options of IntelliSense

Subject: [PATCH] contrib/vscode: respect configurable options of IntelliSense

## tl;dr

4 messages between Feb 4, 2025 and Mar 17, 2025. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

Zejun Zhao· Feb 4, 2025, 12:57 UTC · lore

The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.

Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.

Signed-off-by: Zejun Zhao <jelly.zhao.42@gmail.com>
---
 contrib/vscode/init.sh | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Show changes to contrib/vscode/init.sh +3 −4

diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
index f2d61bb0e6..17f5b6161e 100755
--- a/contrib/vscode/init.sh
+++ b/contrib/vscode/init.sh
@@ -15,8 +15,7 @@ die "Could not create .vscode/"
 
 cat >.vscode/settings.json.new <<\EOF ||
 {
-    "C_Cpp.intelliSenseEngine": "Default",
-    "C_Cpp.intelliSenseEngineFallback": "Disabled",
+    "C_Cpp.intelliSenseEngine": "default",
     "[git-commit]": {
         "editor.wordWrap": "wordWrapColumn",
         "editor.wordWrapColumn": 72
@@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\EOF ||
         "\\Wchar *\\*\\W*utfs\\W",
         "cURL's",
         "nedmalloc'ed",
-        "ntifs\\.h",
-    ],
+        "ntifs\\.h"
+    ]
 }
 EOF
 die "Could not write settings.json"

base-commit: f93ff170b93a1782659637824b25923245ac9dd1

-- 
2.43.0

Patrick Steinhardt· Feb 5, 2025, 07:08 UTC · re: Zejun Zhao · lore

Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense

On Tue, Feb 04, 2025 at 12:57:21PM +0000, Zejun Zhao wrote:

> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.
> 
> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.

Formatting of the commit message is off, as we wrap lines at 72 characters. I cannot really say much about the patch itself. One thing that might help reviewers who aren't familiar with VSCode would be a link to for example release notes that announce the dremoval of the option you're removing.

A bit off-topic: did you by any chance try out our Meson build system? VSCode has a plugin for Meson that you can install, and then you can import the Git project into VSCode directly without using "contrib/vscode".

Patrick

Johannes Schindelin· Mar 16, 2025, 02:37 UTC · re: Zejun Zhao · lore

Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense

Hi Zejun,

On Tue, 4 Feb 2025, Zejun Zhao wrote:

Show 20 quoted lines

> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.
>
> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.
>
> Signed-off-by: Zejun Zhao <jelly.zhao.42@gmail.com>
> ---
>  contrib/vscode/init.sh | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
> index f2d61bb0e6..17f5b6161e 100755
> --- a/contrib/vscode/init.sh
> +++ b/contrib/vscode/init.sh
> @@ -15,8 +15,7 @@ die "Could not create .vscode/"
>
>  cat >.vscode/settings.json.new <<\EOF ||
>  {
> -    "C_Cpp.intelliSenseEngine": "Default",
> -    "C_Cpp.intelliSenseEngineFallback": "Disabled",
> +    "C_Cpp.intelliSenseEngine": "default",

This looks good to me!

Thank you, Johannes

Show 21 quoted lines

>      "[git-commit]": {
>          "editor.wordWrap": "wordWrapColumn",
>          "editor.wordWrapColumn": 72
> @@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\EOF ||
>          "\\Wchar *\\*\\W*utfs\\W",
>          "cURL's",
>          "nedmalloc'ed",
> -        "ntifs\\.h",
> -    ],
> +        "ntifs\\.h"
> +    ]
>  }
>  EOF
>  die "Could not write settings.json"
>
> base-commit: f93ff170b93a1782659637824b25923245ac9dd1
> --
> 2.43.0
>
>
>

Junio C Hamano· Mar 17, 2025, 22:17 UTC · re: Johannes Schindelin · lore

Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

> Hi Zejun,
>
> On Tue, 4 Feb 2025, Zejun Zhao wrote:
>
>> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.
>>
>> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.

Overly long lines. Please wrap lines in your proposed log message at around 70 cols or so.

It explains why removing "fallback" is the right thing to do, but it also wants to explain why we favor "default" over "Default" (and if there is no good reason, that change should be reverted).

>> Signed-off-by: Zejun Zhao <jelly.zhao.42@gmail.com>
>> ---

Other than that, thanks for writing, and thanks for reviewing.

Show 19 quoted lines

>>  contrib/vscode/init.sh | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
>> index f2d61bb0e6..17f5b6161e 100755
>> --- a/contrib/vscode/init.sh
>> +++ b/contrib/vscode/init.sh
>> @@ -15,8 +15,7 @@ die "Could not create .vscode/"
>>
>>  cat >.vscode/settings.json.new <<\EOF ||
>>  {
>> -    "C_Cpp.intelliSenseEngine": "Default",
>> -    "C_Cpp.intelliSenseEngineFallback": "Disabled",
>> +    "C_Cpp.intelliSenseEngine": "default",
>
> This looks good to me!
>
> Thank you,
> Johannes

Show 22 quoted lines

>
>>      "[git-commit]": {
>>          "editor.wordWrap": "wordWrapColumn",
>>          "editor.wordWrapColumn": 72
>> @@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\EOF ||
>>          "\\Wchar *\\*\\W*utfs\\W",
>>          "cURL's",
>>          "nedmalloc'ed",
>> -        "ntifs\\.h",
>> -    ],
>> +        "ntifs\\.h"
>> +    ]
>>  }
>>  EOF
>>  die "Could not write settings.json"
>>
>> base-commit: f93ff170b93a1782659637824b25923245ac9dd1
>> --
>> 2.43.0
>>
>>
>>