{"thread":{"id":"62899","subject":"[PATCH] contrib/vscode: respect configurable options of IntelliSense","startedAt":"2025-02-04T12:57:43Z","lastAt":"2025-03-17T22:17:14Z","messageCount":4,"participants":["Zejun Zhao","Patrick Steinhardt","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"511802","messageId":"20250204125721.11357-1-jelly.zhao.42@gmail.com","threadId":"62899","inReplyTo":null,"subject":"[PATCH] contrib/vscode: respect configurable options of IntelliSense","fromName":"Zejun Zhao","fromEmail":"jelly.zhao.42@gmail.com","sentAt":"2025-02-04T12:57:21Z","receivedAt":"2025-02-04T12:57:43Z","isPatch":true,"sender":{"key":"jelly.zhao.42@gmail.com","avatar":null},"body":"The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.\n\nFix this by strictly respecting the latest configuration manual of VSCode IntelliSense.\n\nSigned-off-by: Zejun Zhao \n---\n contrib/vscode/init.sh | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh\nindex f2d61bb0e6..17f5b6161e 100755\n--- a/contrib/vscode/init.sh\n+++ b/contrib/vscode/init.sh\n@@ -15,8 +15,7 @@ die \"Could not create .vscode/\"\n \n cat >.vscode/settings.json.new <<\\EOF ||\n {\n- \"C_Cpp.intelliSenseEngine\": \"Default\",\n- \"C_Cpp.intelliSenseEngineFallback\": \"Disabled\",\n+ \"C_Cpp.intelliSenseEngine\": \"default\",\n \"[git-commit]\": {\n \"editor.wordWrap\": \"wordWrapColumn\",\n \"editor.wordWrapColumn\": 72\n@@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\\EOF ||\n \"\\\\Wchar *\\\\*\\\\W*utfs\\\\W\",\n \"cURL's\",\n \"nedmalloc'ed\",\n- \"ntifs\\\\.h\",\n- ],\n+ \"ntifs\\\\.h\"\n+ ]\n }\n EOF\n die \"Could not write settings.json\"\n\nbase-commit: f93ff170b93a1782659637824b25923245ac9dd1\n-- \n2.43.0\n\n"},{"id":"511854","messageId":"Z6MOdywCXc48qARV@pks.im","threadId":"62899","inReplyTo":"20250204125721.11357-1-jelly.zhao.42@gmail.com","subject":"Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-02-05T07:08:39Z","receivedAt":"2025-02-05T07:08:43Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Feb 04, 2025 at 12:57:21PM +0000, Zejun Zhao wrote:\n> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.\n> \n> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.\n\nFormatting of the commit message is off, as we wrap lines at 72\ncharacters. I cannot really say much about the patch itself. One thing\nthat might help reviewers who aren't familiar with VSCode would be a\nlink to for example release notes that announce the dremoval of the\noption you're removing.\n\nA bit off-topic: did you by any chance try out our Meson build system?\nVSCode has a plugin for Meson that you can install, and then you can\nimport the Git project into VSCode directly without using\n\"contrib/vscode\".\n\nPatrick\n"},{"id":"514371","messageId":"fdd8e2c6-9adc-4e53-d65c-ba75da0758f9@gmx.de","threadId":"62899","inReplyTo":"20250204125721.11357-1-jelly.zhao.42@gmail.com","subject":"Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2025-03-16T02:37:45Z","receivedAt":"2025-03-16T02:37:47Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Zejun,\n\nOn Tue, 4 Feb 2025, Zejun Zhao wrote:\n\n> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.\n>\n> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.\n>\n> Signed-off-by: Zejun Zhao \n> ---\n> contrib/vscode/init.sh | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n>\n> diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh\n> index f2d61bb0e6..17f5b6161e 100755\n> --- a/contrib/vscode/init.sh\n> +++ b/contrib/vscode/init.sh\n> @@ -15,8 +15,7 @@ die \"Could not create .vscode/\"\n>\n> cat >.vscode/settings.json.new <<\\EOF ||\n> {\n> - \"C_Cpp.intelliSenseEngine\": \"Default\",\n> - \"C_Cpp.intelliSenseEngineFallback\": \"Disabled\",\n> + \"C_Cpp.intelliSenseEngine\": \"default\",\n\nThis looks good to me!\n\nThank you,\nJohannes\n\n> \"[git-commit]\": {\n> \"editor.wordWrap\": \"wordWrapColumn\",\n> \"editor.wordWrapColumn\": 72\n> @@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\\EOF ||\n> \"\\\\Wchar *\\\\*\\\\W*utfs\\\\W\",\n> \"cURL's\",\n> \"nedmalloc'ed\",\n> - \"ntifs\\\\.h\",\n> - ],\n> + \"ntifs\\\\.h\"\n> + ]\n> }\n> EOF\n> die \"Could not write settings.json\"\n>\n> base-commit: f93ff170b93a1782659637824b25923245ac9dd1\n> --\n> 2.43.0\n>\n>\n>\n"},{"id":"514442","messageId":"xmqqy0x3715k.fsf@gitster.g","threadId":"62899","inReplyTo":"fdd8e2c6-9adc-4e53-d65c-ba75da0758f9@gmx.de","subject":"Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-03-17T22:17:11Z","receivedAt":"2025-03-17T22:17:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi Zejun,\n>\n> On Tue, 4 Feb 2025, Zejun Zhao wrote:\n>\n>> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.\n>>\n>> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.\n\nOverly long lines. Please wrap lines in your proposed log message\nat around 70 cols or so.\n\nIt explains why removing \"fallback\" is the right thing to do, but\nit also wants to explain why we favor \"default\" over \"Default\" (and\nif there is no good reason, that change should be reverted).\n\n>> Signed-off-by: Zejun Zhao \n>> ---\n\nOther than that, thanks for writing, and thanks for reviewing.\n\n>> contrib/vscode/init.sh | 7 +++----\n>> 1 file changed, 3 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh\n>> index f2d61bb0e6..17f5b6161e 100755\n>> --- a/contrib/vscode/init.sh\n>> +++ b/contrib/vscode/init.sh\n>> @@ -15,8 +15,7 @@ die \"Could not create .vscode/\"\n>>\n>> cat >.vscode/settings.json.new <<\\EOF ||\n>> {\n>> - \"C_Cpp.intelliSenseEngine\": \"Default\",\n>> - \"C_Cpp.intelliSenseEngineFallback\": \"Disabled\",\n>> + \"C_Cpp.intelliSenseEngine\": \"default\",\n>\n> This looks good to me!\n>\n> Thank you,\n> Johannes\n\n>\n>> \"[git-commit]\": {\n>> \"editor.wordWrap\": \"wordWrapColumn\",\n>> \"editor.wordWrapColumn\": 72\n>> @@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\\EOF ||\n>> \"\\\\Wchar *\\\\*\\\\W*utfs\\\\W\",\n>> \"cURL's\",\n>> \"nedmalloc'ed\",\n>> - \"ntifs\\\\.h\",\n>> - ],\n>> + \"ntifs\\\\.h\"\n>> + ]\n>> }\n>> EOF\n>> die \"Could not write settings.json\"\n>>\n>> base-commit: f93ff170b93a1782659637824b25923245ac9dd1\n>> --\n>> 2.43.0\n>>\n>>\n>>\n"}]}