Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Feb 5, 2025, 07:08 UTC
- Message-ID
- <Z6MOdywCXc48qARV@pks.im>
- In-Reply-To
- <20250204125721.11357-1-jelly.zhao.42@gmail.com>
On Tue, Feb 04, 2025 at 12:57:21PM +0000, Zejun Zhao wrote:
> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings. > > Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.
Formatting of the commit message is off, as we wrap lines at 72 characters. I cannot really say much about the patch itself. One thing that might help reviewers who aren't familiar with VSCode would be a link to for example release notes that announce the dremoval of the option you're removing.
A bit off-topic: did you by any chance try out our Meson build system? VSCode has a plugin for Meson that you can install, and then you can import the Git project into VSCode directly without using "contrib/vscode".
Patrick